stroblmeandClaude Opus 5
b80b92aad7
Docs / docs (push) Successful in 21s
Playwright Tests / test-playwright (1, 2) (push) Successful in 1m57s
Playwright Tests / test-playwright (2, 2) (push) Successful in 1m43s
pre-commit / pre-commit (push) Failing after 3m32s
Test Backend / test-backend (push) Successful in 2m18s
Compose Smoke Test / test-compose (push) Successful in 31s
Playwright Tests / merge-reports (push) Successful in 1m27s
`make test-frontend` built PLAYWRIGHT_BASE_URL from DOMAIN in .env, which in a checkout configured for a deployment is that deployment's domain — so the suite that creates and deletes flows, dashboards and users was pointed at app.fluksio.com, held local only by --add-host and tests/guard.ts. The hostname now comes off the running stack (the frontend container's own Traefik rule), so a name no local container answers to cannot be reached at all, and the local targets default to *.localhost instead of reading .env. Target-specific on purpose: an exported DOMAIN outranks --env-file in compose interpolation and would put the production targets on localhost. `rebuild-frontend` replaces the raw compose line CLAUDE.md spelled out, taking the same domain so the baked VITE_API_URL cannot disagree with what Traefik serves. Also: a coverage HTML report that cannot be written no longer fails test-backend after a green suite, and both artifact actions in playwright.yml drop to @v3, which is the only version without the github.com-only guard that failed every run. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
215 lines
12 KiB
Makefile
215 lines
12 KiB
Makefile
# ─── Fluksio app Makefile ───
|
|
# Convenience targets for development, testing, linting, and deployment.
|
|
# The workspace root delegates to these (see ../Makefile).
|
|
|
|
.PHONY: dev-utils dev dev-local dev-lan rebuild-frontend up down update install dev-backend dev-frontend \
|
|
generate-client sync-example test test-backend test-frontend soak bench-startup lint lint-backend \
|
|
lint-frontend format-frontend umami build docs docs-serve clean help
|
|
|
|
COMPOSE_ROOT := $(CURDIR)
|
|
# Explicit project name keeps this stack isolated from the sibling website
|
|
# stack (otherwise both default to "docker", the directory their compose
|
|
# files live in).
|
|
COMPOSE_PROJECT := fluksio-app
|
|
# Compose interpolation needs the project-local .env before reading compose.yml.
|
|
COMPOSE := docker compose -p $(COMPOSE_PROJECT) --env-file $(COMPOSE_ROOT)/.env
|
|
COMPOSE_PROD := $(COMPOSE) -f docker/compose.yml
|
|
# Production also runs autoheal, which restarts the backend when its deep
|
|
# health check fails. It is profile-gated because it mounts the Docker socket.
|
|
COMPOSE_PROD_RUN := $(COMPOSE_PROD) --profile autoheal
|
|
# Host port `make dev-lan` publishes the frontend on.
|
|
APP_PORT ?= 8080
|
|
COMPOSE_DEV := $(COMPOSE_PROD) -f docker/compose.dev.yml
|
|
# Integrated local stack: dev stack wired onto the shared `proxy` network.
|
|
COMPOSE_LOCAL := $(COMPOSE_DEV) -f docker/compose.local.yml
|
|
# Same stack, with the frontend also published on APP_PORT and proxying the API
|
|
# there, for clients that cannot resolve app.$(DOMAIN).
|
|
COMPOSE_LAN := $(COMPOSE_LOCAL) -f docker/compose.lan.yml
|
|
|
|
help: ## Show available targets
|
|
@awk 'BEGIN{FS=":.*?## "} /^[a-zA-Z_-]+:.*?##/ {printf " \033[36m%-18s\033[0m %s\n", $$1, $$2}' $(MAKEFILE_LIST)
|
|
|
|
# ── Development (Docker) ──────────────────────────────────────────
|
|
|
|
# Hostname the local stack is served under. Never .env's DOMAIN: a checkout
|
|
# configured for a deployment carries that deployment's domain, and a local
|
|
# stack started under it answers to the same names the live installation does.
|
|
# Target-specific on purpose — an exported DOMAIN outranks --env-file in
|
|
# compose interpolation, which would put the *production* targets on localhost.
|
|
# `make dev DOMAIN=fluksio.com` still wins.
|
|
dev dev-utils dev-local dev-lan rebuild-frontend: export DOMAIN ?= localhost
|
|
|
|
dev-utils: ## Start only the utility containers (proxy, mailcatcher)
|
|
$(COMPOSE_DEV) up --build proxy mailcatcher
|
|
|
|
dev: ## Start the full dev stack (includes a local Traefik proxy)
|
|
$(COMPOSE_DEV) up --build
|
|
|
|
dev-local: ## Start the integrated local stack (called by the root `make dev`)
|
|
DOMAIN=$${DOMAIN:-localhost} ENVIRONMENT=$${ENVIRONMENT:-local} \
|
|
$(COMPOSE_LOCAL) up --build -d proxy backend frontend docs mailcatcher
|
|
|
|
dev-lan: ## Same, plus the app on http://<host-ip>:$(APP_PORT) (no DNS needed)
|
|
DOMAIN=$${DOMAIN:-localhost} ENVIRONMENT=$${ENVIRONMENT:-local} APP_PORT=$(APP_PORT) \
|
|
$(COMPOSE_LAN) up --build -d proxy backend frontend mailcatcher
|
|
|
|
# The frontend is an nginx image, so a UI change needs a rebuild. DOMAIN comes
|
|
# off the running stack: VITE_API_URL is baked in at build time, and a rebuild
|
|
# under a different domain leaves the SPA calling an API that answers elsewhere.
|
|
rebuild-frontend: ## Rebuild and restart the local frontend (after a UI change)
|
|
@domain=$$(docker inspect fluksio-app 2>/dev/null \
|
|
| grep -o 'Host(`app\.[^`]*`)' | head -1 | sed 's/Host(`app\.//;s/`)//'); \
|
|
DOMAIN=$${domain:-$$DOMAIN} ENVIRONMENT=$${ENVIRONMENT:-local} \
|
|
$(COMPOSE_LOCAL) up --build -d frontend
|
|
|
|
up: ## Start the production stack
|
|
$(COMPOSE_PROD_RUN) up --build -d
|
|
|
|
umami: ## Provision + start the optional Umami site-analytics service (idempotent)
|
|
# Guard: the dashboard is internet-facing on analytics.$(DOMAIN); refuse to
|
|
# start when its session-signing secret is unset or still the placeholder.
|
|
@secret=$$(grep -E '^UMAMI_APP_SECRET=' $(COMPOSE_ROOT)/.env 2>/dev/null | head -1 | cut -d= -f2-); \
|
|
if [ -z "$$secret" ] || [ "$$secret" = "changethis" ]; then \
|
|
echo "ERROR: UMAMI_APP_SECRET is empty or 'changethis' in .env — run the workspace root's scripts/setup.sh (or set it: openssl rand -hex 32) before 'make umami'." >&2; \
|
|
exit 1; \
|
|
fi
|
|
# --no-recreate: reuse an already-running db instead of recreating it under
|
|
# the prod compose set, which would blip every service that depends on it.
|
|
$(COMPOSE_PROD) up -d --wait --no-recreate db
|
|
# Least-privilege role owning only the umami database, so the third-party
|
|
# image never holds the shared superuser credentials.
|
|
@pguser=$$(grep -E '^POSTGRES_USER=' $(COMPOSE_ROOT)/.env 2>/dev/null | head -1 | cut -d= -f2-); pguser=$${pguser:-postgres}; \
|
|
role=$$(grep -E '^UMAMI_DB_USER=' $(COMPOSE_ROOT)/.env 2>/dev/null | head -1 | cut -d= -f2-); role=$${role:-umami}; \
|
|
pw=$$(grep -E '^UMAMI_DB_PASSWORD=' $(COMPOSE_ROOT)/.env 2>/dev/null | head -1 | cut -d= -f2-); \
|
|
db=$$(grep -E '^UMAMI_DB=' $(COMPOSE_ROOT)/.env 2>/dev/null | head -1 | cut -d= -f2-); db=$${db:-umami}; \
|
|
if [ -z "$$pw" ] || [ "$$pw" = "changethis" ]; then \
|
|
echo "ERROR: UMAMI_DB_PASSWORD is empty or 'changethis' in .env — run the workspace root's scripts/setup.sh before 'make umami'." >&2; \
|
|
exit 1; \
|
|
fi; \
|
|
$(COMPOSE_PROD) exec -T db psql -v ON_ERROR_STOP=1 -U "$$pguser" -d postgres \
|
|
-v role="$$role" -v pw="$$pw" -v db="$$db" < docker/provision-umami-db.sql
|
|
# --no-deps: only (re)create umami, never restart the shared db underneath it.
|
|
$(COMPOSE_PROD) --profile analytics up -d --no-deps umami
|
|
|
|
update: ## Pull, rebuild using the layer cache, and recreate changed containers
|
|
git pull
|
|
$(COMPOSE_PROD_RUN) build
|
|
$(COMPOSE_PROD_RUN) up -d --remove-orphans
|
|
docker image prune -f
|
|
|
|
down: ## Stop all running containers
|
|
-$(COMPOSE_LOCAL) down
|
|
-$(COMPOSE_PROD_RUN) down
|
|
|
|
# ── Development (local, no Docker) ───────────────────────────────
|
|
# Run `make dev-backend` and `make dev-frontend` in two separate terminals.
|
|
|
|
install: ## Install all dependencies (backend + frontend)
|
|
cd backend && uv sync
|
|
cd frontend && bun install
|
|
|
|
dev-backend: ## Start the FastAPI backend with hot-reload (local)
|
|
cd backend && uv run fastapi dev fluksio/main.py
|
|
|
|
dev-frontend: ## Start the Vite dev server (local)
|
|
cd frontend && bun dev
|
|
|
|
generate-client: ## Regenerate the frontend SDK from the backend's OpenAPI schema
|
|
bash scripts/generate-client.sh
|
|
|
|
sync-example: ## Upload `examples/myresearch` the way a data scientist would
|
|
# The same command the docs give, against whichever engine `fluksio login`
|
|
# last talked to. The nodes import the package from this checkout, so the
|
|
# engine has to be one that can see this path.
|
|
cd backend && uv run fluksio sync ../examples/myresearch
|
|
|
|
# ── Testing ───────────────────────────────────────────────────────
|
|
|
|
test: test-backend test-frontend ## Run all tests (backend + frontend)
|
|
|
|
test-backend: ## Run backend tests (pytest + coverage)
|
|
# Its own SQLite file in a temp directory (tests/__init__.py), so this needs
|
|
# nothing running and touches no development data.
|
|
cd backend && uv run bash scripts/test.sh
|
|
|
|
PW_VERSION = $(shell sed -n 's/.*"@playwright\/test": "[^0-9]*\([0-9.]*\)".*/\1/p' frontend/package.json | head -1)
|
|
|
|
# This suite creates and deletes flows, dashboards and users, so the hostname it
|
|
# is pointed at is not taken from any file: it is read off the running stack
|
|
# (the frontend container's own Traefik rule) and mapped onto the local Traefik
|
|
# by address, so DNS never decides. tests/guard.ts is the second line.
|
|
test-frontend: ## Run frontend tests (Playwright e2e) against the local stack
|
|
@ip=$$(docker network inspect proxy \
|
|
--format '{{range .Containers}}{{if eq .Name "fluksio-app-proxy-1"}}{{.IPv4Address}}{{end}}{{end}}' \
|
|
2>/dev/null | cut -d/ -f1); \
|
|
[ -n "$$ip" ] || { echo " ✗ proxy network or Traefik container not found — is the stack up?"; exit 1; }; \
|
|
domain=$$(docker inspect fluksio-app 2>/dev/null \
|
|
| grep -o 'Host(`app\.[^`]*`)' | head -1 | sed 's/Host(`app\.//;s/`)//'); \
|
|
[ -n "$$domain" ] || { echo " ✗ no running app stack to test — 'make dev' first"; exit 1; }; \
|
|
docker run --rm --network proxy --ipc=host \
|
|
--user $$(id -u):$$(id -g) -e HOME=/tmp \
|
|
--add-host app.$$domain:$$ip --add-host api.$$domain:$$ip \
|
|
-v $(COMPOSE_ROOT):/app -w /app/frontend \
|
|
-e PLAYWRIGHT_BASE_URL=http://app.$$domain \
|
|
-e PLAYWRIGHT_API_URL=http://api.$$domain \
|
|
-e HOST_RESOLVER_RULES="MAP app.$$domain $$ip, MAP api.$$domain $$ip" \
|
|
-e CI=$${CI:-1} \
|
|
-e FIRST_SUPERUSER="$$(sed -n 's/^FIRST_SUPERUSER=//p' $(COMPOSE_ROOT)/.env | head -1)" \
|
|
-e FIRST_SUPERUSER_PASSWORD="$$(sed -n 's/^FIRST_SUPERUSER_PASSWORD=//p' $(COMPOSE_ROOT)/.env | head -1)" \
|
|
mcr.microsoft.com/playwright:v$(PW_VERSION)-noble \
|
|
npx playwright test $(PLAYWRIGHT_ARGS)
|
|
|
|
# Load and chaos against a *running* stack, never part of `make test`: it
|
|
# restarts this stack's containers. `SOAK_ARGS="--dry-run"` only looks.
|
|
soak: ## Run the soak/chaos harness (SOAK_ARGS="--minutes 30 --scenario redis")
|
|
cd backend && uv run python scripts/soak.py $(SOAK_ARGS)
|
|
|
|
bench-startup: ## Time submitting a run (BENCH_ARGS="--kedro ../some/kedro/project")
|
|
cd backend && uv run python scripts/bench_startup.py $(BENCH_ARGS)
|
|
|
|
# In-process, so it needs no stack: what a message costs the engine in work
|
|
# and in time. `BENCH_ARGS="--redis <host>"` measures it against a real Redis,
|
|
# which is where the round trips are.
|
|
bench-engine: ## Engine throughput and per-message cost (BENCH_ARGS="--redis localhost")
|
|
cd backend && uv run python scripts/bench_engine.py $(BENCH_ARGS)
|
|
|
|
# ── Linting ───────────────────────────────────────────────────────
|
|
|
|
build: ## Build the fluksio and fluksio-worker wheels into dist/
|
|
uv build --all-packages --out-dir dist
|
|
|
|
lint: lint-backend lint-frontend ## Run all linters
|
|
|
|
lint-backend: ## Lint backend with ruff + mypy
|
|
cd backend && uv run ruff check .
|
|
cd backend && uv run ruff format --check .
|
|
cd backend && uv run mypy fluksio
|
|
cd worker && uv run --no-project --with mypy mypy fluksio_worker
|
|
|
|
lint-frontend: ## Lint frontend with biome
|
|
cd frontend && bun run lint
|
|
|
|
format-frontend: ## Apply biome's fixes to the frontend (what `lint-frontend` only reports)
|
|
cd frontend && bun run format
|
|
|
|
# ── Documentation ─────────────────────────────────────────────────
|
|
# The public site on docs.${DOMAIN}, served by the `docs` service in
|
|
# docker/compose.yml. These targets are for local authoring: zensical runs on
|
|
# demand via uvx, so it never touches the backend environment. Pinned to the
|
|
# version docker/Dockerfile.docs and .gitea/workflows/docs.yml ship, so local
|
|
# authoring builds with what docs.fluksio.com actually gets.
|
|
ZENSICAL := zensical==0.0.46
|
|
|
|
docs: ## Build the documentation site into ./site
|
|
uvx $(ZENSICAL) build --clean
|
|
|
|
docs-serve: ## Serve the documentation site locally with live reload
|
|
uvx $(ZENSICAL) serve
|
|
|
|
# ── Cleanup ───────────────────────────────────────────────────────
|
|
|
|
clean: ## Remove build artifacts and caches
|
|
rm -rf frontend/dist frontend/blob-report frontend/test-results
|
|
rm -rf backend/.pytest_cache backend/htmlcov site
|
|
find backend -type d -name __pycache__ -exec rm -rf {} + 2>/dev/null || true
|