Docs / docs (push) Successful in 30s
Playwright Tests / test-playwright (1, 2) (push) Successful in 3m7s
Playwright Tests / test-playwright (2, 2) (push) Successful in 1m54s
pre-commit / pre-commit (push) Failing after 4m24s
Test Backend / test-backend (push) Successful in 3m8s
Compose Smoke Test / test-compose (push) Successful in 40s
Playwright Tests / merge-reports (push) Successful in 1m33s
A port may now declare `image`, `audio` or `video`. Each is the artifact
reference the engine already had, narrowed by the `media_type` on it, so a
speech recogniser declares what it eats rather than taking any bytes at all and
finding out. Bytes still never travel as a message and nothing on the wire
stops being JSON: a camera publishes one reference per frame, a microphone one
per chunk, and a reference may carry a `meta` dict nothing here interprets.
Streaming media is therefore an ordinary streaming port — with one change to
what that means. An emission used to journal an item with no payload, so
downstream read whatever was current when the item was claimed; a consumer
slower than its producer saw only the newest chunk and the ones between were
lost. That is right for a training curve and wrong for a second of speech, so
an emission now journals a `kind="emission"` item carrying its values, and the
executor hands them to the nodes reading that message instead of writing them
to state again. The value in state stays the latest, which is what everything
else reads, and the wave is filtered by what actually changed rather than
walking everything reachable. No queue serialization change — the existing
`outputs` field carries it.
Continuous media makes the store's missing GC a real problem, so this closes
it: `sweep_artifacts` runs hourly, keeps every digest a `run_artifact` row
records or a live message holds, spares anything written in the last hour, and
stands aside entirely while a run is in flight, since a node may store a
checkpoint long before it returns the reference to it. That also collects the
orphans a deleted flow has always left behind. `ARTIFACT_GC_INTERVAL_S=0` turns
it off.
Around the edges: `GET /artifacts/{digest}` serves the media type the caller
passes and answers ranged requests, so a browser plays a clip rather than
downloading it; `PUT` spools to disk instead of holding the whole body in
memory, as does `save_artifact` given a path; a Media widget draws whatever its
message points at, and a wall panel may fetch the bytes its own tiles are
showing and nothing else; and a connector gets `save_artifact`, for a device
whose readings are bytes.
What this cannot do is live video: a frame every second or two is a glance, and
the honest answer above that is the camera's own stream, which the widget takes
as a URL and the browser plays from source.
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
153 lines
5.5 KiB
Python
153 lines
5.5 KiB
Python
"""The artifact store: bytes a node produced, addressed by their content.
|
|
|
|
A typed message carries JSON, which is what lets the same value pass through
|
|
Redis, the work queue and the worker protocol unchanged. A model checkpoint is
|
|
not that, so it does not travel as a message — it is written here and the
|
|
message carries a reference to it.
|
|
|
|
Addressed by digest rather than by run, for three reasons. A sweep whose fifty
|
|
configs share one preprocessed input stores it once. A reference stays valid
|
|
however it is passed around, because it names content instead of a location.
|
|
And the digest is what a stage cache will compare, so building it in now is
|
|
what keeps that from being a change to the message contract later.
|
|
"""
|
|
|
|
from __future__ import annotations
|
|
|
|
import contextlib
|
|
import hashlib
|
|
import logging
|
|
import os
|
|
import tempfile
|
|
import time
|
|
from collections.abc import Iterable, Iterator
|
|
from pathlib import Path
|
|
from typing import Any
|
|
|
|
logger = logging.getLogger(__name__)
|
|
|
|
#: How much is read at a time when hashing or serving.
|
|
CHUNK = 1024 * 1024
|
|
DIGEST_PREFIX = "sha256:"
|
|
|
|
|
|
def is_reference(value: Any) -> bool:
|
|
"""Whether a message payload is an artifact reference."""
|
|
return isinstance(value, dict) and str(value.get("digest", "")).startswith(
|
|
DIGEST_PREFIX
|
|
)
|
|
|
|
|
|
def valid_digest(digest: str) -> bool:
|
|
"""Guard for anything that reaches the filesystem from outside."""
|
|
if not digest.startswith(DIGEST_PREFIX):
|
|
return False
|
|
body = digest[len(DIGEST_PREFIX) :]
|
|
return len(body) == 64 and all(c in "0123456789abcdef" for c in body)
|
|
|
|
|
|
class ArtifactStore:
|
|
"""Content-addressed files under one directory."""
|
|
|
|
def __init__(self, root: Path) -> None:
|
|
self.root = root
|
|
self.root.mkdir(parents=True, exist_ok=True)
|
|
|
|
def _path(self, digest: str) -> Path:
|
|
body = digest[len(DIGEST_PREFIX) :]
|
|
# Two levels, so a directory listing stays usable at a hundred thousand
|
|
# artifacts.
|
|
return self.root / body[:2] / body
|
|
|
|
def put(
|
|
self, chunks: Iterable[bytes], name: str = "", media_type: str = ""
|
|
) -> dict[str, Any]:
|
|
"""Store a stream and return the reference to it.
|
|
|
|
Written to a temporary file first and moved into place once the digest
|
|
is known, so a half-written artifact never has a name anyone can find.
|
|
A file already there is left alone: identical content is identical.
|
|
"""
|
|
digester = hashlib.sha256()
|
|
size = 0
|
|
handle = tempfile.NamedTemporaryFile(dir=self.root, delete=False)
|
|
try:
|
|
with handle:
|
|
for chunk in chunks:
|
|
digester.update(chunk)
|
|
size += len(chunk)
|
|
handle.write(chunk)
|
|
digest = DIGEST_PREFIX + digester.hexdigest()
|
|
target = self._path(digest)
|
|
target.parent.mkdir(parents=True, exist_ok=True)
|
|
if target.exists():
|
|
os.unlink(handle.name)
|
|
else:
|
|
# Same content from two nodes at once is one rename winning and
|
|
# the other replacing a byte-identical file.
|
|
os.replace(handle.name, target)
|
|
except BaseException:
|
|
with contextlib.suppress(OSError):
|
|
os.unlink(handle.name)
|
|
raise
|
|
return {
|
|
"digest": digest,
|
|
"size": size,
|
|
"media_type": media_type or "application/octet-stream",
|
|
"name": name,
|
|
}
|
|
|
|
def put_file(
|
|
self, path: Path, media_type: str = "", name: str = ""
|
|
) -> dict[str, Any]:
|
|
with path.open("rb") as handle:
|
|
return self.put(
|
|
iter(lambda: handle.read(CHUNK), b""),
|
|
name=name or path.name,
|
|
media_type=media_type,
|
|
)
|
|
|
|
def path(self, digest: str) -> Path | None:
|
|
"""Where the bytes are, or None if this store does not have them."""
|
|
if not valid_digest(digest):
|
|
return None
|
|
target = self._path(digest)
|
|
return target if target.exists() else None
|
|
|
|
def read(self, digest: str) -> Iterator[bytes]:
|
|
target = self.path(digest)
|
|
if target is None:
|
|
raise FileNotFoundError(digest)
|
|
with target.open("rb") as handle:
|
|
while chunk := handle.read(CHUNK):
|
|
yield chunk
|
|
|
|
def collect(self, keep: set[str], grace_s: float = 0.0) -> int:
|
|
"""Delete what nothing refers to any more. Returns how many went.
|
|
|
|
The caller passes every digest still recorded; anything else in the
|
|
store was produced by a run that has since been pruned, or never got a
|
|
row at all because the run failed between writing and recording.
|
|
|
|
``grace_s`` spares anything written that recently. Storing bytes and
|
|
recording the reference to them are two steps, and a sweep landing
|
|
between them would take an artifact its run is about to name — so
|
|
recent files are left for the next pass, by which time they are either
|
|
referenced or genuinely orphaned.
|
|
"""
|
|
removed = 0
|
|
cutoff = time.time() - grace_s
|
|
for entry in self.root.glob("*/*"):
|
|
if not entry.is_file():
|
|
continue
|
|
if DIGEST_PREFIX + entry.name in keep:
|
|
continue
|
|
try:
|
|
if grace_s > 0 and entry.stat().st_mtime > cutoff:
|
|
continue
|
|
entry.unlink()
|
|
removed += 1
|
|
except OSError:
|
|
logger.warning("Could not remove artifact %s", entry.name)
|
|
return removed
|