stroblmeandClaude Opus 5
c912388ed6
`make lint-frontend` was `biome check --write --unsafe ./` — a lint target that reformatted the whole tree rather than checking it, which is why every parallel change in this repo has had to work around it. `lint` checks now and a new `format` writes. The pre-commit hook and CI needed no edit at all: both call `bun run lint`, so they became checks the moment its meaning changed. `app/Makefile` assigned DOMAIN from .env, and a plain assignment beats an inherited environment variable and is not exported — so `cd app && make dev-local` served localhost while the same checkout's tests targeted the configured domain. `export DOMAIN ?=` gives the lattice that was intended: command line, then environment, then .env. Alongside: the backend's htmlcov bind mount created that directory as root, so `make test-backend` died on the coverage step after every test had passed, which reads like a test failure and is not one. The alerts screen's copy of ALERTING_EVENTS is now checked by a test rather than trusted. And the shard comment claimed two spec files where there are nine. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Uq8mtNb97A7praJLyeEYgs
109 lines
3.8 KiB
YAML
109 lines
3.8 KiB
YAML
name: Playwright Tests
|
|
|
|
on:
|
|
push:
|
|
branches:
|
|
- main
|
|
paths:
|
|
- backend/**
|
|
- frontend/**
|
|
- docker/compose*.yml
|
|
- .env.example
|
|
- .gitea/workflows/playwright.yml
|
|
pull_request:
|
|
types:
|
|
- opened
|
|
- synchronize
|
|
paths:
|
|
- backend/**
|
|
- frontend/**
|
|
- docker/compose*.yml
|
|
- .env.example
|
|
- .gitea/workflows/playwright.yml
|
|
|
|
env:
|
|
# The playwright runner service comes from the dev overlay. It loads the SPA
|
|
# from the nginx `frontend` service and reaches the API as http://backend:8000
|
|
# on the project network — both wired up in compose.ci.yml.
|
|
COMPOSE_FILE: docker/compose.yml:docker/compose.dev.yml:docker/compose.ci.yml
|
|
# frontend/playwright.config.ts keys the blob reporter, the retries and
|
|
# forbidOnly off CI, and compose.dev.yml forwards it into the container.
|
|
CI: "true"
|
|
|
|
jobs:
|
|
test-playwright:
|
|
runs-on: ubuntu-latest
|
|
timeout-minutes: 60
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
# Nine spec files under tests/, plus tests/auth.setup.ts, which every
|
|
# shard reruns as its setup project. Split two ways: each shard pays a
|
|
# full compose stack's startup, so more of them would spend more time
|
|
# booting than testing.
|
|
shardIndex: [1, 2]
|
|
shardTotal: [2]
|
|
env:
|
|
# One stack per shard, so a `down -v` cannot reach the other shard's
|
|
# volumes. compose.ci.yml above drops the fixed container_names and host
|
|
# ports, which the project name does not cover — without it two shards on
|
|
# the same runner host collide on the daemon-global names.
|
|
COMPOSE_PROJECT_NAME: fluksio-app-ci-pw-${{ matrix.shardIndex }}
|
|
steps:
|
|
- name: Checkout
|
|
uses: actions/checkout@v4
|
|
- name: Write .env
|
|
# Not committed; compose interpolates it and the runner container reads
|
|
# FIRST_SUPERUSER / FIRST_SUPERUSER_PASSWORD out of it (tests/config.ts).
|
|
run: cp .env.example .env
|
|
- run: docker compose build backend frontend playwright
|
|
- run: docker compose down -v --remove-orphans
|
|
# PLAYWRIGHT_BASE_URL points the browser at `frontend`, which is not a
|
|
# dependency of the playwright service, so bring it up explicitly.
|
|
- run: docker compose up -d --wait backend frontend
|
|
- name: Run Playwright tests
|
|
run: >-
|
|
docker compose run --rm playwright
|
|
bunx playwright test --trace=retain-on-failure
|
|
--shard=${{ matrix.shardIndex }}/${{ matrix.shardTotal }}
|
|
- name: Tear down
|
|
if: always()
|
|
run: docker compose down -v --remove-orphans
|
|
- name: Upload blob report
|
|
if: ${{ !cancelled() }}
|
|
uses: actions/upload-artifact@v4
|
|
with:
|
|
name: blob-report-${{ matrix.shardIndex }}
|
|
path: frontend/blob-report
|
|
include-hidden-files: true
|
|
retention-days: 1
|
|
|
|
merge-reports:
|
|
needs:
|
|
- test-playwright
|
|
# Merge even when a shard failed — that report is the one worth reading.
|
|
if: ${{ !cancelled() }}
|
|
runs-on: ubuntu-latest
|
|
steps:
|
|
- name: Checkout
|
|
uses: actions/checkout@v4
|
|
- uses: oven-sh/setup-bun@v2
|
|
- name: Install dependencies
|
|
run: bun install --frozen-lockfile
|
|
- name: Download blob reports
|
|
uses: actions/download-artifact@v4
|
|
with:
|
|
path: frontend/all-blob-reports
|
|
pattern: blob-report-*
|
|
merge-multiple: true
|
|
- name: Merge into an HTML report
|
|
run: bunx playwright merge-reports --reporter html ./all-blob-reports
|
|
working-directory: frontend
|
|
- name: Upload HTML report
|
|
uses: actions/upload-artifact@v4
|
|
with:
|
|
name: html-report--attempt-${{ github.run_attempt }}
|
|
path: frontend/playwright-report
|
|
include-hidden-files: true
|
|
retention-days: 7
|