9 Commits

Include renames

Author	SHA1	Message	Date
stroblmeandClaude Opus 5	57eace2226	Bound what the API accepts, and close the holes the audit found ... **SQLite is the database, and now says so.** `metric_minute` and every run table are written with `sqlalchemy.dialects.sqlite.insert(...) .on_conflict_do_update` and with `max(a, b)`, neither of which another dialect has — so pointing `DATABASE_URL` at Postgres migrated cleanly, served, logged in, and then lost every observability flush into the collector's hold buffer and failed every run. It refuses at startup instead. (The Postgres in the compose stack is Umami's; the engine's own database has been a file beside the flows since 2026-08-21.) **Every integer query parameter is bounded.** The caps were written as `min(limit, 500)`, which a negative walks straight through — `?limit=-1` compiles to `LIMIT -1` and SQLite returns the whole table. Ten signatures, now `Query(ge=…, le=…)`. `hours=0` still means an hour, which `_window_hours` was already deliberate about. **Exports are capped at 10 000 runs** and say so with `X-Truncated`. The filters bounded a sensible request and nothing bounded an unfiltered one, which read every row into memory before a byte was streamed. `_series` resolves cached curves in two queries rather than a `Run` lookup and a `RunMetric` query per restored node — a comparison of twenty runs was calling that twenty times over. **`PUT /artifacts` has a size limit** (`MAX_ARTIFACT_BYTES`, 2 GiB, 0 to disable), checked against `Content-Length` and again against the stream for a chunked body, and its writes moved off the event loop. **`/observability/timeseries` takes `since`/`until`**, the same window `/runs` and `/events` take, capped at 2000 points — `hours=720&bucket_s=60` was 43 200 of them in one array. It is also what a dragged chart needs to re-fetch at its own resolution rather than magnifying buckets it has. **Composite indexes** for the three list screens: `run(flow, created_at)` and `(status, created_at)`, `flow_run(flow, started_at)`, `engine_event(type, ts)`. Every index was single-column, so SQLite picked one and sorted the rest by hand. Verified against a copy of a live database (250k `flow_run` rows): the planner takes all four. **Redis clients have socket timeouts.** A Redis that stops answering without closing the connection hung the caller until the kernel gave up — including `/utils/health/`, whose job is to notice. **The panels file is written under one lock.** `save_panels` and `unpair_panel` are both read-modify-write, and a save that read before an unpair wrote put the old nonce back — silently un-revoking a screen that had just been unpaired. The nonce carry-forward was written to make that impossible; the gap between its read and its write is where it happened. **Startup releases what it acquired.** Everything past `event_bus.bind` registers how to close itself and the `finally` walks that list backwards; a failure part-way through used to reach none of the shutdown steps and leave the worker pool's subprocesses and every background task behind — under `--reload`, once per bad edit. `modules.reconcile` moved into the background: `uv` gets five minutes twice over, the healthcheck allows eighty seconds, and the autoheal restarted the container before it could finish installing. `delete_run` takes SQLite's write lock up front (`core.db.writing`) rather than upgrading a deferred transaction and losing to whichever flush committed in between. `modules.sync` is serialised — two applies mutated one venv at once. The proxied-call and stream dicts are bounded, and a reused id cancels its predecessor instead of dropping the reference. Security, found in passing and small enough to fix here: - **`/secrets/` required only a signed-in user.** The names alone say what this installation talks to, and `PUT /{name}` takes any name, so any account could overwrite the credential a flow authenticates with. Superuser now — which `/search` already assumed and said so. - **`POST /login/access-token` had no rate limit.** Argon2 is deliberately expensive and the route is unauthenticated and runs in the shared threadpool. Ten *failed* attempts per address per five minutes; a successful sign-in spends nothing. - **a password reset link worked repeatedly for 48 hours.** The token now carries a digest of the password hash it was minted against, so it stops verifying once it has set one. No table of spent tokens needed. - **enrolment accepted `http://`**, sending the claim code and then this installation's credential in clear. https, or a local address. - the rate limiter read `request.client.host`, which behind Traefik is the proxy — so every per-address limit was one global bucket and one caller could lock out everyone. It reads the forwarded address, and its bucket table is capped rather than growing one key per address forever. - SMTP has a timeout and sends after the response, so an unreachable mail host cannot pin a threadpool worker, and a reply's timing no longer says whether the address exists. Test suite: engine-written rows are cleared between modules. A `FlowRun` left `running` by one module turned up in another's query. Per-test rollback is not available here — the module-scoped `client` runs the real lifespan and its collector and run service write through sessions of their own — so this bounds it where the writes come from. Three consecutive green runs, orders randomised. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M6hPWS6YEbT1P8LxhhFb2T	2026-08-29 20:40:05 +02:00
stroblmeandClaude Opus 5	da528340a9	Cut the round trips a message costs the engine ... Measured with `make bench-engine` against a real Redis: 103.6 -> 164.4 messages a second on a five-node chain (p50 latency 2125 -> 1171 ms) and 34.8 -> 63.2 on a fan-out of twenty. Against the memory backend, which is what a pip install runs on, 262 -> 626. The two that bought most of it: - `StateBackend.record` puts a published value, its timestamp, its series and its version counter in one round trip. They were four calls building four pipelines, and a value crossing an edge pays them twice. A released rate-limit hold rides along instead of a DEL per port. - the readiness check reads a node's inputs and hands them to the node, rather than reading the triggering ones to count them and having the node read the same keys again a moment later. `apply_outputs` was a second copy of `_record_outputs` and is now the same code plus the event that distinguishes it. The rest, each small: - `_derive` builds a node-by-id map and a `consumes` index, so dispatching an item and publishing a value stop scanning every node in the installation. - `read_all` is memoised against the store revision — it sits on the publish path, so a dashboard slider was reading and validating every flow file per value. Same mechanism `_wiring` already uses. - the `message_value` source block is built once per node instead of per emission. - both timer threads ask the queue to promote only when something is actually due, which takes an idle engine from ~4 Redis round trips a second to one. - the shared httpx client is bounded (32 connections, one retry); its default pool is 100 with no per-host cap, so one slow endpoint could take it and every other sender node with it. - the MQTT and delay nodes no longer log a line per message at INFO. Robustness, in the same pass: - `MemoryWorkQueue._done` was a set nothing ever removed from — one entry per non-idempotent node per item, for the life of the process, in the default configuration. Capped, the way the Redis side expires its markers. - a saturated engine can claim from the due lane past the cascade limit. The capacity gate sits in front of the claim, so the due lane's priority — decided inside it — did not apply while every slot was held: a motor's stop was not behind the long nodes, it was unread. Only after a slot has genuinely failed to free for half a second, and briefly, so the backlog is not starved in turn. - `reclaim_stale` dispatches through that same gate. It could return sixty entries and push in-flight far past the limit the gate exists to hold. - a flow's nodes are stopped together rather than one after another. Each gets `NODE_STOP_TIMEOUT`, so a flow whose broker was unreachable took five seconds per node — long enough to outlast `REBUILD_WAIT` and 503 the deploy. - the worker pool and the HTTP client are closed on a thread, not on the event loop, and a run closes the state backend it built (on Redis, a client and a connection pool per run). - the five background tasks say something when they die. Each catches exceptions inside its loop, so one raised anywhere else left the engine serving with no metrics, no alerts or no artifact sweep, silently. `tests/flow/test_round_trips.py` counts the state operations one message costs — four, where it was about eleven — because none of the above would fail a behavioural test if it were undone. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01M6hPWS6YEbT1P8LxhhFb2T	2026-08-29 19:58:39 +02:00
stroblmeandClaude Opus 5	c3675688c8	Wait for a deadline instead of polling for one ... The timer thread promoted due work on a fixed one-second tick, so every delayed item was 0-1000ms late whatever the load — measured on the house at 705ms mean on a rollershutter stop, which is 2-4% of a 26-second travel and accumulates in the position the motor node believes it is at. It now sleeps to the soonest deadline and is woken when a nearer one is scheduled, which measures 0.9ms end to end through Redis. A promoted timer also went to the back of the queue. It goes into a due lane of its own that `claim` reads first, so work that has waited out a deadline is not held up by work that is merely queued. Beside it, in the same code: seeding a message now bumps its version, so a re-put flow's synchronous nodes no longer wait forever on a value that is sitting in state; the consumer group drops the consumers of engines that are gone (138 had accumulated on this installation); and the cast that closes the long-standing `xclaim` mypy error. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>	2026-08-27 11:51:58 +02:00
stroblmeandClaude Opus 5	0ffcabfdb9	Media dtypes: image, audio and video as narrowed artifact references ... A port may now declare `image`, `audio` or `video`. Each is the artifact reference the engine already had, narrowed by the `media_type` on it, so a speech recogniser declares what it eats rather than taking any bytes at all and finding out. Bytes still never travel as a message and nothing on the wire stops being JSON: a camera publishes one reference per frame, a microphone one per chunk, and a reference may carry a `meta` dict nothing here interprets. Streaming media is therefore an ordinary streaming port — with one change to what that means. An emission used to journal an item with no payload, so downstream read whatever was current when the item was claimed; a consumer slower than its producer saw only the newest chunk and the ones between were lost. That is right for a training curve and wrong for a second of speech, so an emission now journals a `kind="emission"` item carrying its values, and the executor hands them to the nodes reading that message instead of writing them to state again. The value in state stays the latest, which is what everything else reads, and the wave is filtered by what actually changed rather than walking everything reachable. No queue serialization change — the existing `outputs` field carries it. Continuous media makes the store's missing GC a real problem, so this closes it: `sweep_artifacts` runs hourly, keeps every digest a `run_artifact` row records or a live message holds, spares anything written in the last hour, and stands aside entirely while a run is in flight, since a node may store a checkpoint long before it returns the reference to it. That also collects the orphans a deleted flow has always left behind. `ARTIFACT_GC_INTERVAL_S=0` turns it off. Around the edges: `GET /artifacts/{digest}` serves the media type the caller passes and answers ranged requests, so a browser plays a clip rather than downloading it; `PUT` spools to disk instead of holding the whole body in memory, as does `save_artifact` given a path; a Media widget draws whatever its message points at, and a wall panel may fetch the bytes its own tiles are showing and nothing else; and a connector gets `save_artifact`, for a device whose readings are bytes. What this cannot do is live video: a frame every second or two is a glance, and the honest answer above that is the camera's own stream, which the widget takes as a URL and the browser plays from source. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>	2026-08-26 23:44:55 +02:00
stroblmeandClaude Opus 5	180da3d640	Stop paying five Redis round trips and a global lock per message ... The engine was I/O-bound on its own state backend. `RedisState.lock()` is one key — `pipeline:_lock` — for the whole process, taken five times a message at two round trips each, and every cascade and every node read queued behind it. Inside it, reading a node's inputs was three round trips per input (an EXISTS for `in`, then EXISTS and GET for the value), writing was two updates that a single transaction already gives, and the version counters went one INCR at a time. Replaced with the atomic command that was always available: `get_present` is one MGET and tells a missing key from one holding null, so the lock it used to be read under bought nothing; value and timestamp land in one `update`, which is a MULTI/EXEC; `increment_multi` pipelines the counters. `values()` — what every websocket snapshot calls — is two reads whatever the message count instead of two per message. Beside that: every webhook did its blocking XADD on the asyncio event loop (MQTT already used `to_thread`); the per-execution `NodeOutcome` was built and validated even with no run watching; `_minute` built a tz-aware datetime per event on the loop thread to key a dict, and now keys on an int; `move_due` promoted delayed items one round trip each, every second; `FLOW_MAX_CASCADES` makes the in-flight ceiling a setting rather than a constant. `orjson` replaces stdlib json where a message pays for it — state, the journal, the engine side of the worker pipe. `fluksio-worker` stays dependency-free, and the run-cache digest stays on stdlib so no stored key is invalidated. A non-finite number now stores as `null` rather than the bare `NaN` that was never JSON. Measured with `scripts/bench_engine.py` against a real Redis, 200 messages: a five-node chain went from 43.9 to 103.1 msg/s with p50 latency 2110ms → 782ms and p95 3913ms → 1439ms; one source into twenty consumers went from 5.4 to 33.7 msg/s. In memory, twenty consumers went from 187 to 448 msg/s. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BpfSinyCBfjuieikyfMPbf	2026-08-26 10:12:25 +02:00
stroblmeandClaude Opus 5	5726c80948	Say how much work is waiting, not just how much is running ... `RedisWorkQueue.stats` read XPENDING, which counts entries delivered to a consumer and not yet acknowledged — work in progress. Entries sitting in the stream undelivered were counted nowhere, so an engine hours behind reported itself idle: on the house, `pending: 4` while the group's lag was 1554. The group's own `lag` is the missing number. `backlog` now carries it on both queues (`len(_items)` in memory), leads the health tile, and a sustained one publishes `engine_degraded` from the timer thread — named with the flow most of the waiting work belongs to, sampled from the undelivered tail, since that is the actionable half. It is a summary problem rather than a /utils/health 503: a backlog should not restart the container. Also drops the keyspace `scan_iter` `stats()` did per poll to count parked items — it walked every state and idempotency key twice per ten seconds — for a set the park/unpark path maintains. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BpfSinyCBfjuieikyfMPbf	2026-08-26 09:43:23 +02:00
stroblmeandClaude Opus 5	4941c2787c	Add fluksio status, and ask for a run's parameters at a terminal ... Two halves of the same gap: the CLI could start work but not show you any. `fluksio status` draws the home screen's top half in a terminal — health and what is wrong with it, every flow with its state and node count, and the recent runs and failures under them. `--watch` keeps it there. Rich does the drawing; it was already installed under fastapi's own CLI, and is named now because a command depends on it. `fluksio run` with no parameters at a terminal asks for them, one line per declared input with its declared value in brackets — so Enter through the lot is what running the defaults looks like, and an artifact input takes the `@run:` spelling the engine now resolves. A scripted run is untouched: passing any parameter, or piping the command, skips the questions, as does --defaults. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019V5bsYGNxcgPs4xXmTPx69	2026-08-25 07:42:09 +02:00
stroblmeandClaude Opus 5	93374a310e	Refuse what a node cannot publish, and stop timing out work that is fine ... Four things the python SDK turned up, each fixed where every client sees it. A key no port declares is now an error rather than a silent drop, on the return, the yield and the emit alike — the contract the docs already stated. The SDK reads literal yields at sync time, so a typo fails before anything runs, and an emission of one fails the call rather than being logged where nobody looks. NaN and infinity are refused at the port. JSON cannot spell either, so one that travelled came back as a 500, a socket frame that stopped the canvas, or a metric batch the database dropped whole. An artifact input takes `@run:<id>.<output>` or a bare digest, resolved on the engine — so the CLI, the run dialog and a python caller mean the same thing, and a sweep can pass one at all. Node timeouts are off by default. The clock measured silence, which a training node is full of, and remote workers had already stopped enforcing it — their heartbeat reset it. Now a heartbeat proves the agent rather than the node, ninety seconds of nothing fails the call either way, and the engine touches work it is still running so a long node is not redelivered at sixty seconds. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019V5bsYGNxcgPs4xXmTPx69	2026-08-25 07:30:14 +02:00
stroblmeandClaude Opus 5	60d7ec81c0	Rename the import package app to fluksio ... A wheel whose top-level module is `app` collides with anything else in a user's venv, so the package that is about to be published takes the name it is published under. Only the Python package moves; the repo, the Docker WORKDIR and the compose project keep theirs. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>	2026-08-21 21:48:05 +02:00