Camera permission and review fixes (openpanel C3, C4)
C4: a device's `viewers` (superusers by default, or members) covers the image and video messages its ports publish. Anyone else gets none of their values on the socket, in the catalogue or a flow's state, 403 for their history, for the frames they hold (the last 8 included) and for TURN credentials, no bytes when asking for them, and `bye: forbidden` for a live view. A device credential stays bounded by its dashboards. The device page sets it in its Camera section, and a tile the viewer may not see says "No access to this camera" and asks the camera for nothing. C3: - A volatile upload is held to MAX_FRAME_BYTES (4 MiB, 413 above it, read without extra copies), and so is a frame on a device's socket. - A frame the engine holds in memory is written to the ring directory before a local worker is handed it, so load_artifact finds it. - A socket the bus dropped events for catches up with a snapshot, demand included, and a device's credential is checked again per frame, cached by the flow store revision and its nonce, so a lost event never keeps an unpaired device's frames coming. - A report is at most 64 KB once its named config_schemas are put in place. - A device away for 60 s has its true bool messages set to false. - Refused frames are logged by fixed keys, a frame is named after its message, `fluksio serve` waits 5 s for open connections, a tile with a stream URL creates no demand, the 8-name cap keeps the newest names. - Every container's log rotates (json-file, 3 x 10 MB). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0138N7k5PT4dcR1iEqXaaQ9k
This commit is contained in:
co-authored by
Claude Opus 5.5
parent
02b736c9e8
commit
f679264b3a
@@ -44,6 +44,7 @@ import {
|
||||
type DeviceReport,
|
||||
deviceNodeOf,
|
||||
freeNodeId,
|
||||
hasCamera,
|
||||
LIVE_PORT,
|
||||
type ReportedPort,
|
||||
reportedPorts,
|
||||
@@ -141,7 +142,7 @@ export function DeviceDetail({ id }: { id: string }) {
|
||||
<section className={cn(CARD, "grid gap-4")}>
|
||||
<Basics device={device} canEdit={canEdit} onChange={write} />
|
||||
</section>
|
||||
<Camera device={device} />
|
||||
<Camera device={device} canEdit={canEdit} onChange={write} />
|
||||
<section className={CARD}>
|
||||
<Dashboards device={device} canEdit={canEdit} onChange={write} />
|
||||
</section>
|
||||
@@ -219,33 +220,81 @@ function Basics({
|
||||
)
|
||||
}
|
||||
|
||||
/** Who may see a device's camera, as the setting reads. */
|
||||
const VIEWERS = {
|
||||
superusers: "Superusers",
|
||||
members: "All members",
|
||||
} as const
|
||||
|
||||
/**
|
||||
* What the device's camera sees, once a flow wires its `camera` port.
|
||||
* Who may watch the device's camera, and what it sees once a flow wires its
|
||||
* `camera` port.
|
||||
*
|
||||
* Watching is what turns the camera on: it sends frames only while this
|
||||
* preview, a tile or a flow reading them wants them.
|
||||
*/
|
||||
function Camera({ device }: { device: DevicePublic }) {
|
||||
function Camera({
|
||||
device,
|
||||
canEdit,
|
||||
onChange,
|
||||
}: {
|
||||
device: DevicePublic
|
||||
canEdit: boolean
|
||||
onChange: (changes: Partial<DeviceDef>) => void
|
||||
}) {
|
||||
if (!hasCamera(device)) return null
|
||||
const bound = (device.bindings ?? []).find(
|
||||
(binding) => binding.port === "camera" && binding.direction === "in",
|
||||
)
|
||||
if (!bound) return null
|
||||
return (
|
||||
<section className={CARD}>
|
||||
<PanelSection
|
||||
title="Camera"
|
||||
help="Frames while this preview is on screen, which the camera sends only while someone watches them here or on a dashboard, or a running flow reads them. Tap it for live video when the device streams live."
|
||||
>
|
||||
<div
|
||||
className="flex aspect-video w-full overflow-hidden rounded-md bg-muted text-center text-sm"
|
||||
data-testid="device-camera"
|
||||
>
|
||||
<MediaView
|
||||
message={bound.message}
|
||||
fit="contain"
|
||||
label={`${device.title || device.id} camera`}
|
||||
/>
|
||||
<div className="flex items-center gap-2 text-sm">
|
||||
<span className="flex-1">Who may watch</span>
|
||||
<InfoTip label="Who may watch">
|
||||
Its pictures, their history and its live view: superusers only, or
|
||||
every member of this instance. A wall panel shows the camera when
|
||||
one of its dashboards carries it. Whoever edits flows can still pass
|
||||
the pictures on through a node.
|
||||
</InfoTip>
|
||||
<Select
|
||||
value={device.viewers ?? "superusers"}
|
||||
disabled={!canEdit}
|
||||
onValueChange={(viewers) =>
|
||||
onChange({ viewers: viewers as DeviceDef["viewers"] })
|
||||
}
|
||||
>
|
||||
<SelectTrigger
|
||||
className="w-40"
|
||||
aria-label="Who may watch"
|
||||
data-testid="device-viewers"
|
||||
>
|
||||
<SelectValue />
|
||||
</SelectTrigger>
|
||||
<SelectContent>
|
||||
{Object.entries(VIEWERS).map(([value, label]) => (
|
||||
<SelectItem key={value} value={value}>
|
||||
{label}
|
||||
</SelectItem>
|
||||
))}
|
||||
</SelectContent>
|
||||
</Select>
|
||||
</div>
|
||||
{bound ? (
|
||||
<div
|
||||
className="flex aspect-video w-full overflow-hidden rounded-md bg-muted text-center text-sm"
|
||||
data-testid="device-camera"
|
||||
>
|
||||
<MediaView
|
||||
message={bound.message}
|
||||
fit="contain"
|
||||
label={`${device.title || device.id} camera`}
|
||||
/>
|
||||
</div>
|
||||
) : null}
|
||||
</PanelSection>
|
||||
</section>
|
||||
)
|
||||
|
||||
@@ -63,6 +63,30 @@ export function screensOf(devices: DevicePublic[] = []) {
|
||||
})
|
||||
}
|
||||
|
||||
/** What a device's `viewers` setting covers: what a camera sends. */
|
||||
const CAMERA_DTYPES: readonly string[] = ["image", "video"]
|
||||
|
||||
/** The messages a device's camera publishes, its image and video `in` ports. */
|
||||
export const cameraMessages = (device: DevicePublic) =>
|
||||
(device.bindings ?? [])
|
||||
.filter(
|
||||
(binding) =>
|
||||
binding.direction === "in" &&
|
||||
CAMERA_DTYPES.includes(binding.dtype ?? ""),
|
||||
)
|
||||
.map((binding) => binding.message)
|
||||
|
||||
/**
|
||||
* Whether a device has a camera to say who may watch: one it reports, or an
|
||||
* image or video port wired in a flow.
|
||||
*/
|
||||
export const hasCamera = (device: DevicePublic) =>
|
||||
cameraMessages(device).length > 0 ||
|
||||
(reportedPorts(device) ?? []).some(
|
||||
(port) =>
|
||||
port.direction === "in" && CAMERA_DTYPES.includes(port.dtype ?? ""),
|
||||
)
|
||||
|
||||
/** Whether a reported port may be wired in `direction`. `live` never is. */
|
||||
export const wiresAs = (port: ReportedPort, direction: "in" | "out") =>
|
||||
port.port !== LIVE_PORT &&
|
||||
|
||||
Reference in New Issue
Block a user