Camera permission and review fixes (openpanel C3, C4)

C4: a device's `viewers` (superusers by default, or members) covers the
image and video messages its ports publish. Anyone else gets none of their
values on the socket, in the catalogue or a flow's state, 403 for their
history, for the frames they hold (the last 8 included) and for TURN
credentials, no bytes when asking for them, and `bye: forbidden` for a live
view. A device credential stays bounded by its dashboards. The device page
sets it in its Camera section, and a tile the viewer may not see says
"No access to this camera" and asks the camera for nothing.

C3:
- A volatile upload is held to MAX_FRAME_BYTES (4 MiB, 413 above it, read
  without extra copies), and so is a frame on a device's socket.
- A frame the engine holds in memory is written to the ring directory
  before a local worker is handed it, so load_artifact finds it.
- A socket the bus dropped events for catches up with a snapshot, demand
  included, and a device's credential is checked again per frame, cached by
  the flow store revision and its nonce, so a lost event never keeps an
  unpaired device's frames coming.
- A report is at most 64 KB once its named config_schemas are put in place.
- A device away for 60 s has its true bool messages set to false.
- Refused frames are logged by fixed keys, a frame is named after its
  message, `fluksio serve` waits 5 s for open connections, a tile with a
  stream URL creates no demand, the 8-name cap keeps the newest names.
- Every container's log rotates (json-file, 3 x 10 MB).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0138N7k5PT4dcR1iEqXaaQ9k
This commit is contained in:
Melvin Strobl
2026-10-17 09:20:04 +02:00
co-authored by Claude Opus 5.5
parent 02b736c9e8
commit f679264b3a
36 changed files with 1268 additions and 152 deletions
@@ -6,7 +6,7 @@ import { isRef, useArtifactUrl } from "@/lib/media"
import { cn } from "@/lib/utils"
import { useBoundValue } from "./dataContext"
import { config, text } from "./ui/core/config"
import { useLiveDevice, useLiveView } from "./useLiveView"
import { useCameraHidden, useLiveDevice, useLiveView } from "./useLiveView"
import type { WidgetProps } from "./widgets"
/**
@@ -66,10 +66,15 @@ export function MediaView({
const ref = isRef(value) ? value : null
const kind = (ref?.media_type ?? dtype).split("/")[0]
const playing = kind === "audio" || kind === "video"
const camera = useLiveDevice(stream ? "" : message)
// Only superusers may see this camera: nothing is asked of it.
const hidden = useCameraHidden(message)
const camera = useLiveDevice(stream || hidden ? "" : message)
const live = useLiveView(camera)
const onAir = live.phase === "playing"
const active = (shown || playing) && !onAir
// A stream URL draws the picture itself, all but sound: the message's
// bytes would only be demand on a camera nothing shows.
const draws = (!stream || kind === "audio") && !hidden
const active = (shown || playing) && !onAir && draws
const url = useArtifactUrl(
active ? ref : null,
active ? message || undefined : undefined,
@@ -116,6 +121,13 @@ export function MediaView({
if (!message && !stream) {
return <p className="text-muted-foreground">Pick a message.</p>
}
if (hidden) {
return (
<p className="text-muted-foreground" data-testid="media-no-access">
No access to this camera
</p>
)
}
if (!ref) {
return <p className="text-muted-foreground">Nothing published yet.</p>
}
@@ -1,13 +1,18 @@
import { useQuery } from "@tanstack/react-query"
import { useCallback, useEffect, useRef, useState } from "react"
import { LIVE_PORT, reportedPorts } from "@/components/Devices/ports"
import {
cameraMessages,
LIVE_PORT,
reportedPorts,
} from "@/components/Devices/ports"
import { devicesQueryOptions } from "@/components/Devices/queries"
import {
type LiveSignal,
listenLive,
sendLive,
} from "@/components/Flow/useFlowSocket"
import useAuth from "@/hooks/useAuth"
import { appRoute } from "@/lib/portal"
/** How long a live view gets from the tap to its first frame. */
@@ -45,6 +50,29 @@ export function useLiveDevice(message: string): string {
return device?.id ?? ""
}
/**
* Whether this viewer may not see the camera publishing `message`: a
* device's image or video while its `viewers` are superusers, for anyone
* else. The server holds the frames back too, this only says why the tile
* stays empty.
*
* A wall panel shows what its dashboards carry, which a superuser assigned,
* and cannot read the device list anyway.
*/
export function useCameraHidden(message: string): boolean {
const { user } = useAuth()
const enabled =
Boolean(message) &&
!appRoute().startsWith("/panel") &&
user?.is_superuser === false
const { data } = useQuery({ ...devicesQueryOptions(), enabled })
if (!enabled) return false
return (data?.data ?? []).some(
(device) =>
device.viewers !== "members" && cameraMessages(device).includes(message),
)
}
/**
* A live view of one device's camera: the browser's own `RTCPeerConnection`
* answering the device's offer, signalled over the page's socket.