A batch run skips the nodes waiting on a failed one and ends error; a run whose nodes cannot load fails with the load error before anything executes; cancelling a run stops its pipeline without announcing a pause of the live flow; batch_issues refuses a delay node's interval; the client accepts an engine URL with or without /api/v1; RedisState's compare-and-swap records the names it writes
This commit is contained in:
@@ -148,6 +148,17 @@ class RebuildBusy(RuntimeError):
|
||||
"""
|
||||
|
||||
|
||||
class NodesNotLoaded(RuntimeError):
|
||||
"""A run's flow has nodes that could not be built, so none of it runs."""
|
||||
|
||||
def __init__(self, errors: dict[str, str]) -> None:
|
||||
#: The load error of each node, by its qualified id.
|
||||
self.errors = errors
|
||||
node, error = next(iter(errors.items()))
|
||||
more = f" and {len(errors) - 1} more" if len(errors) > 1 else ""
|
||||
super().__init__(f"Node '{node}'{more} could not be loaded: {error}")
|
||||
|
||||
|
||||
class NodeStatus(str, Enum):
|
||||
ACTIVE = "active"
|
||||
ERROR = "error"
|
||||
@@ -2010,10 +2021,21 @@ class FlowController:
|
||||
and webhooks would only be a second copy of what the live pipeline
|
||||
already holds. The state is the run's, which is what keeps two runs of
|
||||
one flow from overwriting each other's messages.
|
||||
|
||||
:raises NodesNotLoaded: When a node could not be built. The live engine
|
||||
leaves such a node out, but a run without it would finish as if
|
||||
the flow had done its work.
|
||||
"""
|
||||
nodes, _loaded, initial_values, _inputs = self._build_flows(
|
||||
nodes, loaded, initial_values, _inputs = self._build_flows(
|
||||
[(flow, draft)], run=run
|
||||
)
|
||||
errors = {
|
||||
entry.id: entry.error or "unknown error"
|
||||
for entry in loaded.values()
|
||||
if entry.status is NodeStatus.ERROR
|
||||
}
|
||||
if errors:
|
||||
raise NodesNotLoaded(errors)
|
||||
pipeline = Pipeline(
|
||||
nodes=nodes,
|
||||
state=state,
|
||||
|
||||
Reference in New Issue
Block a user