Rename the trigger node type to debounce, migrating stored flows
The store rewrites `"type": "trigger"` to `debounce` in every published and draft flow when it opens, bumps the version and commits once. No alias stays behind, so `trigger` is now an unknown type.
This commit is contained in:
@@ -8,8 +8,8 @@ come up than to go down.
|
||||
|
||||
from fluksio.flow.messages import DType, MessageSpec
|
||||
from fluksio.flow.nodes import MqttNode
|
||||
from fluksio.flow.nodes.debounce import DebounceNode
|
||||
from fluksio.flow.nodes.mqtt import topic_matches
|
||||
from fluksio.flow.nodes.trigger import TriggerNode
|
||||
|
||||
# ── MQTT topic filters ────────────────────────────────────────────────────
|
||||
|
||||
@@ -72,7 +72,7 @@ def test_without_json_key_the_port_name_is_the_key_as_before():
|
||||
assert node.json_keys == {}
|
||||
|
||||
|
||||
# ── trigger: passthrough and a per-message wait ───────────────────────────
|
||||
# ── debounce: passthrough and a per-message wait ──────────────────────────
|
||||
|
||||
|
||||
class _Pipeline:
|
||||
@@ -87,8 +87,8 @@ class _Pipeline:
|
||||
return True
|
||||
|
||||
|
||||
def _trigger(**params) -> tuple[TriggerNode, _Pipeline]:
|
||||
node = TriggerNode(
|
||||
def _debounce(**params) -> tuple[DebounceNode, _Pipeline]:
|
||||
node = DebounceNode(
|
||||
requires=[
|
||||
MessageSpec(name="run", port="run", dtype=DType.STR),
|
||||
MessageSpec(name="run_for", port="run_for", dtype=DType.FLOAT),
|
||||
@@ -103,30 +103,30 @@ def _trigger(**params) -> tuple[TriggerNode, _Pipeline]:
|
||||
|
||||
|
||||
def test_the_incoming_value_passes_through_and_the_wait_comes_from_a_port():
|
||||
node, pipeline = _trigger()
|
||||
node, pipeline = _debounce()
|
||||
|
||||
assert node._trigger({}, run="DOWN", run_for=28.0) == {"cmd": "DOWN"}
|
||||
assert node._debounce({}, run="DOWN", run_for=28.0) == {"cmd": "DOWN"}
|
||||
(outputs, seconds, _guard) = pipeline.deferred[-1]
|
||||
assert outputs == {"shutters.cmd": "STOP"} and seconds == 28.0
|
||||
|
||||
node._trigger({}, run="UP", run_for=26.0)
|
||||
node._debounce({}, run="UP", run_for=26.0)
|
||||
assert pipeline.deferred[-1][1] == 26.0
|
||||
|
||||
|
||||
def test_a_second_command_invalidates_the_stop_the_first_one_scheduled():
|
||||
node, pipeline = _trigger()
|
||||
node._trigger({}, run="DOWN", run_for=28.0)
|
||||
node, pipeline = _debounce()
|
||||
node._debounce({}, run="DOWN", run_for=28.0)
|
||||
first = pipeline.deferred[-1][2]
|
||||
node._trigger({}, run="UP", run_for=26.0)
|
||||
node._debounce({}, run="UP", run_for=26.0)
|
||||
assert pipeline.deferred[-1][2] != first
|
||||
|
||||
|
||||
def test_a_wait_of_zero_sends_nothing_afterwards():
|
||||
"""STOP is commanded once. Nothing follows it, forever."""
|
||||
node, pipeline = _trigger()
|
||||
node._trigger({}, run="DOWN", run_for=28.0)
|
||||
node, pipeline = _debounce()
|
||||
node._debounce({}, run="DOWN", run_for=28.0)
|
||||
scheduled = len(pipeline.deferred)
|
||||
|
||||
assert node._trigger({}, run="STOP", run_for=0.0) == {"cmd": "STOP"}
|
||||
assert node._debounce({}, run="STOP", run_for=0.0) == {"cmd": "STOP"}
|
||||
assert len(pipeline.deferred) == scheduled
|
||||
assert node.recall("armed", 0) == 0
|
||||
|
||||
Reference in New Issue
Block a user