Fluksio/app
0
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Let the canvas endpoints be moved, and lift them on hover

Browse Source 
Three things they were missing: they could not be dragged out of the lane
they were placed in, they stayed the same weight whether or not you were
reaching for one, and the label sat right against its connector dot.

Where one has been dragged to is a view preference, not part of the flow —
writing a position for a dashboard widget into flow.json would be a lie
about what the document holds — so it lives in the browser, keyed by flow.

Also folds the dashboard shot into `make verify` and drops the one-off
scripts that had accumulated beside it; the durable coverage is the
Playwright specs, which all pass.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_011LF61rxW1FG5YCD2J9YqjY
This commit is contained in:
stroblme
2026-08-16 16:07:07 +02:00
co-authored by Claude Fable 5
parent 75c26ef000
commit c70359af67
9 changed files with 129 additions and 318 deletions
Download Patch File Download Diff File Expand all files Collapse all files
NOTEPAD.md
+29 -32
View File
@@ -22,12 +22,29 @@ Deferring because out of scope is fine, but don't mention deferring than.
- BUG/UI: clicking outside the panel does not discard the flow edit panel
- FEAT/UX: for the same type of node show suggestions in the setting fields based on other nodes; I.e. if I create an mqtt node and I already configured one in another flow, allow selecting the values of the exiting mqtt node as a drop-down option (identical to consumables) when clicking inside the corresponding field in the new node (same for all other nodes)
- BUG/UI: the graph showed in the node edit panel should also be shown for a specific edge inside the pop-up panel when clicking the edge
- PERF/FLOW: every save rebuilds the whole pipeline. Fine at the current flow count; rebuild
only the touched flow when it starts to show.
- FEAT/UI: the chart widget is stored and validated but not drawn — it is filtered out of
the editor's add row. Needs a charting library and the `--chart-*` tokens below.
- FEAT/UI: dashboard widgets are sized with a wider/narrower control rather than dragged.
A grid library would give drag-and-resize and per-breakpoint layouts; the document
already stores layout per breakpoint, so only the editor changes.
- FEAT/UI/MOBILE: dashboards render in the padded admin shell, so a wall panel gets the
sidebar, footer and a `max-w-7xl` column. A full-bleed shell would suit a panel better.
- FEAT/UI: reintroduce `--chart-*` tokens as one designed sequential scale when the first
chart lands. The node sparkline draws one series in `--primary` and needs none.
- FEAT/FLOW: single-stepping a paused flow. The work queue it needed now exists: pausing
parks claimed items per flow and resuming drains them, so a step button is a matter of
popping one parked item instead of all of them.
- FEAT/UI: interrupting a node that is already running. Pause holds nodes that have not been
submitted yet; one already executing runs to completion.
- FEAT/UI: flow-level edits (title, inputs) go through `FlowPanel.onChange` and stay outside
the undo stack.
- BUG/UI: the enlarged panel (for code editing) should still maintain its floating style
- FEAT/UI: no screen for alerting. Channels and rules are API-only (`/alerts/config`),
so setting up a phone notification means calling the endpoint by hand.
- FEAT/UI: there is no screen for managing the secrets store itself. A node parameter marked
`x-secret` offers the stored secrets, but they can only be created through the API. We should introduce ad dedicated page (in the sidebar) to handle secrets in a centralized way
- BUG/UI: `SidePanel`'s mobile branch does not set `data-testid` on the `SheetContent`, so
`[data-testid=node-panel]` does not exist on a phone. Mobile specs cannot address the panel.
- CHORE/API: node source saves carry no version precondition, so two clients editing the same
@@ -43,18 +60,12 @@ Deferring because out of scope is fine, but don't mention deferring than.
- CHORE/INFRA: `requires-python` is capped below 3.14 because the MCP SDK wants a newer
starlette there than the pinned `sentry-sdk<2` allows. Lift the cap when sentry-sdk moves
to 2.x.
- FEAT/UI: no screen for alerting. Channels and rules are API-only (`/alerts/config`),
so setting up a phone notification means calling the endpoint by hand.
- FEAT/UI: there is no screen for managing the secrets store itself. A node parameter marked
`x-secret` offers the stored secrets, but they can only be created through the API.
- FEAT/FLOW: input discretization drops the trailing edge — if a producer goes quiet inside
the window, the consumer never sees the last value. Delivering it at the end of the window
needs a timer per (node, port).
- CHORE/FLOW: shared node sources bypass the draft/publish split. Editing one writes the
library copy and reloads immediately, since the code is not any single flow's to hold back.
Deliberate, but it means a shared node is the one thing publish does not gate.
- FEAT/UI: flow-level edits (title, inputs) go through `FlowPanel.onChange` and stay outside
the undo stack.
- CHORE/UI: `make test-backend` cannot reach Postgres while the integrated stack is up —
`compose.local.yml` does `db: ports: !reset []`. Run it against the container's address, or
move the suite inside the compose network.
@@ -68,26 +79,12 @@ Deferring because out of scope is fine, but don't mention deferring than.
- CHORE/INFRA: `test-backend.yml` runs pytest on the runner host, so it keeps the fixed
container name and port 5432 that `compose.ci.yml` resets everywhere else. Two concurrent
runs of that one job collide.
- PERF/UI: (deferred for now) the Monaco chunk is 2.6 MB. It only loads when a node panel opens, but the
editor could be trimmed further or swapped for CodeMirror if that becomes a problem.
- CHORE/FLOW: four modules of `app/flow/nodes/` are still excluded from strict mypy
(`[[tool.mypy.overrides]]` in `pyproject.toml`): `mqtt`, `http`, `influx` and `delay`. They
carry prototype typing, `croniter` ships no stubs and `influxdb_client` does not re-export
its names. `base` and `mlp` are checked; shrink the rest as each integration is revisited.
- FEAT/UI: an endpoint's edge routes straight across the graph, so it can pass behind a
node that sits between the lane and the node it wires to. Readable, but a routed edge
would be tidier.
- CHORE/FLOW: a node function returning something other than a dict raises `AttributeError`
in `Node._to_messages` rather than a named error. Outputs are keyed by port, so a non-dict
cannot be one — say so where the return value is mapped.
- PERF/FLOW: every save rebuilds the whole pipeline. Fine at the current flow count; rebuild
only the touched flow when it starts to show.
- FEAT/UI: the chart widget is stored and validated but not drawn — it is filtered out of
the editor's add row. Needs a charting library and the `--chart-*` tokens below.
- FEAT/UI: dashboard widgets are sized with a wider/narrower control rather than dragged.
A grid library would give drag-and-resize and per-breakpoint layouts; the document
already stores layout per breakpoint, so only the editor changes.
- FEAT/UI/MOBILE: dashboards render in the padded admin shell, so a wall panel gets the
sidebar, footer and a `max-w-7xl` column. A full-bleed shell would suit a panel better.
- FEAT/UI: reintroduce `--chart-*` tokens as one designed sequential scale when the first
chart lands. The node sparkline draws one series in `--primary` and needs none.
- PERF/UI: the app's entry chunk is 680 kB (210 kB gzipped) and exceeds the warning
threshold. React Flow and Monaco are already lazy; a manualChunks split measured no better,
so this needs route-level work on the shell rather than chunking config.
@@ -95,23 +92,23 @@ Deferring because out of scope is fine, but don't mention deferring than.
- CHORE/INFRA: `bun run --filter frontend build` fails on this workspace with
`crypto.hash is not a function` — Vite 7 wants Node 20.12+ and the host has 18. The
Docker image builds fine, so it only bites local bundling; `bunx tsc` still type-checks.
- PERF/UI: (deferred for now) the Monaco chunk is 2.6 MB. It only loads when a node panel opens, but the
editor could be trimmed further or swapped for CodeMirror if that becomes a problem.
- CHORE/FLOW: four modules of `app/flow/nodes/` are still excluded from strict mypy
(`[[tool.mypy.overrides]]` in `pyproject.toml`): `mqtt`, `http`, `influx` and `delay`. They
carry prototype typing, `croniter` ships no stubs and `influxdb_client` does not re-export
its names. `base` and `mlp` are checked; shrink the rest as each integration is revisited.
- FEAT/NODE: the connectors only read. Enable the write paths with someone watching:
WF-RAC `setAirconStat` (needs an operatorId registered with the unit first, which is
itself a write) and Art-Net `transmit`.
- FEAT/NODE: the second WF-RAC unit (the one Node-RED addresses with operatorId "0")
closes the connection on an anonymous read. It likely wants an account registered;
the first unit answers without one.
- CHORE/NODE: `wfrac` reports `mode` as "unknown" while the unit is off, because the
mode bits hold a value outside the known set. Faithful to the reference decoder, but
"off" would read better.
- FEAT/UI: an endpoint's edge routes straight across the graph, so it can pass behind a
node that sits between the lane and the node it wires to. Readable, but a routed edge
would be tidier.
- FEAT/UI: endpoints are always shown. A flow read by a twenty-tile wall panel gets twenty
labels, and only the input ones affect the graph — dimming or collapsing consumers is
the obvious next move if it turns out busy.
- FEAT/NODE: the second WF-RAC unit (the one Node-RED addresses with operatorId "0")
closes the connection on an anonymous read. It likely wants an account registered;
the first unit answers without one.
## Blocked