Apply the chart cursor correction exactly once
uPlot writes what `cursor.move` returns back into the value it hands in next time and calls it again on every redraw — and a chart sets its data on every render. The correction was therefore applied repeatedly: the cursor walked left while the pointer stood still, and the position taken at mousedown no longer matched the one held at mouseup, which uPlot reads as a drag and answers by swallowing the click. That is what stopped a chart tile being selectable in the dashboard editor. The refiner now returns its previous answer unchanged when handed it back, so a redraw is a no-op. Lifted out of the config as `cursorRefiner` so the branch can be checked without a browser; `cursor.check.ts` replays uPlot's own sequences, including the press-is-not-a-drag one that regressed. The Playwright hover test now also asserts the cursor holds its place across a redraw, which is what the first version missed. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016ZeGnqVsf5VHQqvz4HdUhN
This commit is contained in:
@@ -0,0 +1,81 @@
|
||||
/**
|
||||
* The cursor refiner, checked.
|
||||
*
|
||||
* ponytail: a script rather than a suite, like the two beside `ColorWidget` —
|
||||
* the frontend's only runner is Playwright and this is arithmetic:
|
||||
*
|
||||
* cd frontend && bun run src/components/Common/cursor.check.ts
|
||||
*
|
||||
* Written because the first version of this shipped a regression Playwright
|
||||
* only caught two tests later. uPlot hands `cursor.move` its own output back
|
||||
* and calls it again on every redraw, so refining a second time walked the
|
||||
* cursor left and — worse — made a still pointer look like a drag, which uPlot
|
||||
* answers by swallowing the click. The sequences below are uPlot's own:
|
||||
* `mouseLeft1` is set raw from the event, refined in place by `updateCursor`,
|
||||
* and then fed back in unchanged by every later redraw.
|
||||
*/
|
||||
|
||||
import assert from "node:assert/strict"
|
||||
|
||||
import { cursorRefiner } from "./UplotChart"
|
||||
|
||||
/** What a panel scaled to fit a 1280x720 window is drawn at. */
|
||||
const DRAWN = 0.64
|
||||
|
||||
// Unscaled — Health and Home — is untouched, whatever the sequence.
|
||||
{
|
||||
const refine = cursorRefiner()
|
||||
for (const at of [0, 12, 300, -10]) {
|
||||
assert.deepEqual(refine(1, at, at), [at, at], `${at} is left alone at 1:1`)
|
||||
}
|
||||
}
|
||||
|
||||
// One pointer move, then the redraws a live dashboard does on every render.
|
||||
// The position must not move while the pointer does not.
|
||||
{
|
||||
const refine = cursorRefiner()
|
||||
const [left, top] = refine(DRAWN, 128, 64)
|
||||
assert.equal(left, 200, "128 visual pixels is 200 layout pixels at 0.64")
|
||||
assert.equal(top, 100)
|
||||
for (let redraw = 0; redraw < 25; redraw++) {
|
||||
const again = refine(DRAWN, left, top)
|
||||
assert.deepEqual(again, [left, top], `redraw ${redraw} moved the cursor`)
|
||||
}
|
||||
}
|
||||
|
||||
// What a click is, in uPlot's own terms: `mouseLeft1` follows the move and
|
||||
// every redraw after it, `mouseLeft0` is refined from the raw press on its
|
||||
// own, and uPlot calls it a drag when the two disagree. They must not, or the
|
||||
// click is swallowed and the dashboard never hears it.
|
||||
{
|
||||
const refine = cursorRefiner()
|
||||
let [left1, top1] = refine(DRAWN, 128, 64)
|
||||
for (let redraw = 0; redraw < 3; redraw++) {
|
||||
;[left1, top1] = refine(DRAWN, left1, top1)
|
||||
}
|
||||
const [left0, top0] = refine(DRAWN, 128, 64)
|
||||
assert.deepEqual(
|
||||
[left1, top1],
|
||||
[left0, top0],
|
||||
"a press where the pointer already was is not a drag",
|
||||
)
|
||||
}
|
||||
|
||||
// A real drag still reads as one.
|
||||
{
|
||||
const refine = cursorRefiner()
|
||||
const from = refine(DRAWN, 128, 64)
|
||||
const to = refine(DRAWN, 192, 64)
|
||||
assert.notDeepEqual(to, from, "a pointer that moved has moved")
|
||||
}
|
||||
|
||||
// Leaving the plot: uPlot parks the cursor off-plot at -10, and it has to stay
|
||||
// off-plot however it is scaled, or the line would stick where it was.
|
||||
{
|
||||
const refine = cursorRefiner()
|
||||
refine(DRAWN, 128, 64)
|
||||
const [left, top] = refine(DRAWN, -10, -10)
|
||||
assert.ok(left < 0 && top < 0, "the parked cursor stays off the plot")
|
||||
}
|
||||
|
||||
console.log("cursor: ok")
|
||||
Reference in New Issue
Block a user