Health: a flow that cannot run says so, and the brain marks which neurons

A dependency loop is flagged on the canvas and was invisible everywhere else:
/observability/summary answered "ok" with an empty problems list while the
published flow could not run at all. It now reports the flows validation
blocks, and the brain graph carries the reason on each neuron the issue names
so the view built to find broken wiring can show it.

Node errors stay counted once, as the nodes that failed to load, and an
advisory like an unauthenticated webhook marks nothing — it is worth saying,
but the flow still runs.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XC2jX6Hdj7pxGGKzBTrbqB
This commit is contained in:
2026-08-17 14:39:07 +02:00
co-authored by Claude Opus 5
parent 3b5241bb9a
commit a1265450df
7 changed files with 143 additions and 2 deletions
+47 -1
View File
@@ -68,10 +68,56 @@ def test_the_summary_answers_even_when_degraded(
assert response.status_code == 200
body = response.json()
assert body["status"] in {"ok", "degraded"}
assert set(body["flows"]) == {"total", "running", "paused", "quarantined"}
assert set(body["flows"]) == {
"total",
"running",
"paused",
"quarantined",
"invalid",
}
assert "error" in body["nodes"]
def test_a_flow_that_cannot_run_makes_the_summary_degraded(
client: TestClient, superuser_token_headers: dict[str, str]
) -> None:
"""A loop on the canvas has to reach the health screen.
Validation runs on a build, not on this request, so what the engine already
knows is what this reports — and reporting it is the whole point: a flow
with a dependency loop cannot run, and the screen used to say "ok".
"""
from app.flow.pipeline import ValidationIssue
controller = client.app.state.flow_controller
before = controller.issues
controller.issues = [
ValidationIssue(
code="cycle",
message="These nodes depend on each other in a loop",
flow="looping",
nodes=["looping.a", "looping.b"],
),
# Already counted as a node that failed to load, so not again here.
ValidationIssue(
code="node_error", message="boom", flow="broken", node="broken.x"
),
ValidationIssue(
code="unauthenticated_hook", message="open", flow="hooky", node="hooky.h"
),
]
try:
body = client.get(f"{PREFIX}/summary", headers=superuser_token_headers).json()
finally:
controller.issues = before
assert body["status"] == "degraded"
assert body["flows"]["invalid"] == 1
assert any("looping" in problem for problem in body["problems"])
assert not any("broken" in problem for problem in body["problems"])
assert not any("hooky" in problem for problem in body["problems"])
def test_the_history_reads_back(
client: TestClient, superuser_token_headers: dict[str, str], db: Session
) -> None:
+36
View File
@@ -12,6 +12,7 @@ import pytest
from app.flow.controller import FlowController
from app.flow.messages import DType, MessageSpec
from app.flow.nodes import MqttNode
from app.flow.pipeline import ValidationIssue
from app.flow.schemas import FlowDef, NodeDef
from app.flow.store import FlowStore
@@ -80,3 +81,38 @@ def test_a_credential_never_reaches_the_key():
key = MqttNode.instance_key({**BROKER, "password": {"$secret": "broker_pw"}})
assert key == "mosquitto:1883/sensors/temp"
def test_a_neuron_carries_what_stops_it_running(controller: FlowController):
# Validation runs on a build, so the graph on its own knows nothing yet.
assert all(node.issue is None for node in controller.brain_graph().nodes)
controller.issues = [
ValidationIssue(
code="cycle",
message="These nodes depend on each other in a loop",
flow="house",
nodes=["house.scale", "house.sensor"],
)
]
graph = controller.brain_graph()
# Both named nodes are marked, the merged neuron among them, and the flow
# that has nothing wrong with it is left alone.
assert {node.id: node.issue is not None for node in graph.nodes} == {
"house.scale": True,
"mqtt:mosquitto:1883/sensors/temp": True,
}
def test_an_advisory_issue_leaves_the_graph_clean(controller: FlowController):
controller.issues = [
ValidationIssue(
code="unauthenticated_hook",
message="Webhook 'hook' has no secret",
flow="house",
node="house.scale",
)
]
assert all(node.issue is None for node in controller.brain_graph().nodes)