Request log: a hook's secret is masked in uvicorn's lines and the tunnel connector's failure line
Claude-Session: https://claude.ai/code/session_01SSi5AvZ7pFmySK8zy3NPMh
This commit is contained in:
@@ -1,4 +1,4 @@
|
||||
"""A credential in a query string stays out of uvicorn's request lines."""
|
||||
"""A credential in a query string or a hook's path stays out of uvicorn's request lines."""
|
||||
|
||||
import logging
|
||||
|
||||
@@ -52,3 +52,29 @@ def test_the_pairing_secret_is_not_logged() -> None:
|
||||
assert [record.getMessage() for record in records] == [
|
||||
'192.0.2.1:0 - "GET /api/v1/devices/pair/ABCD2345?secret=*** HTTP/1.1" 202'
|
||||
]
|
||||
|
||||
|
||||
def test_a_hooks_secret_is_not_logged() -> None:
|
||||
records: list[logging.LogRecord] = []
|
||||
handler = logging.Handler()
|
||||
handler.emit = records.append # type: ignore[method-assign]
|
||||
log = logging.getLogger("uvicorn.access")
|
||||
level = log.level
|
||||
log.addHandler(handler)
|
||||
log.setLevel(logging.INFO)
|
||||
try:
|
||||
for path in (
|
||||
"/hooks/home/tick/s3cr3t",
|
||||
"/hooks/home/a/b/s3cr3t?x=1",
|
||||
"/hooks/home//s3cr3t",
|
||||
):
|
||||
log.info('%s - "%s %s HTTP/%s" %d', "192.0.2.1:0", "POST", path, "1.1", 202)
|
||||
finally:
|
||||
log.removeHandler(handler)
|
||||
log.setLevel(level)
|
||||
|
||||
assert [record.getMessage() for record in records] == [
|
||||
'192.0.2.1:0 - "POST /hooks/home/tick/*** HTTP/1.1" 202',
|
||||
'192.0.2.1:0 - "POST /hooks/home/a/b/***?x=1 HTTP/1.1" 202',
|
||||
'192.0.2.1:0 - "POST /hooks/home//*** HTTP/1.1" 202',
|
||||
]
|
||||
|
||||
Reference in New Issue
Block a user