Button icon-touch/sm-touch sizes replace the repeated touch-target classes

This commit is contained in:
2026-10-12 22:02:35 +02:00
parent 59272299f5
commit 237b9d96c6
8 changed files with 49 additions and 61 deletions
@@ -22,10 +22,6 @@ import {
} from "@/components/ui/tooltip" } from "@/components/ui/tooltip"
import useCustomToast from "@/hooks/useCustomToast" import useCustomToast from "@/hooks/useCustomToast"
import { transitions } from "@/lib/motion" import { transitions } from "@/lib/motion"
import { cn } from "@/lib/utils"
/** The icon buttons here and in the flow dock are the same touch target. */
const ICON = "size-11 text-muted-foreground md:size-8"
/** /**
* The bar over the flows and dashboards lists: find one, publish what is * The bar over the flows and dashboards lists: find one, publish what is
@@ -113,8 +109,8 @@ export function OverviewToolbar({
<Button <Button
ref={trigger} ref={trigger}
variant="ghost" variant="ghost"
size="icon" size="icon-touch"
className={ICON} className="text-muted-foreground"
aria-label={searchLabel} aria-label={searchLabel}
onClick={() => setOpen(true)} onClick={() => setOpen(true)}
> >
@@ -130,8 +126,8 @@ export function OverviewToolbar({
{selectedCount > 0 ? ( {selectedCount > 0 ? (
<Button <Button
variant="ghost" variant="ghost"
size="icon" size="icon-touch"
className={cn(ICON, "text-destructive")} className="text-destructive"
aria-label={`Delete ${selectedCount} selected`} aria-label={`Delete ${selectedCount} selected`}
data-testid="delete-selected" data-testid="delete-selected"
onClick={onDeleteSelected} onClick={onDeleteSelected}
@@ -142,8 +138,8 @@ export function OverviewToolbar({
<DialogTrigger asChild> <DialogTrigger asChild>
<Button <Button
variant="ghost" variant="ghost"
size="icon" size="icon-touch"
className={ICON} className="text-muted-foreground"
aria-label={createLabel} aria-label={createLabel}
data-testid={createTestId} data-testid={createTestId}
> >
@@ -164,8 +160,8 @@ export function OverviewToolbar({
<span> <span>
<Button <Button
variant="ghost" variant="ghost"
size="icon" size="icon-touch"
className={ICON} className="text-muted-foreground"
disabled={draftCount === 0 || publishing} disabled={draftCount === 0 || publishing}
onClick={onPublishAll} onClick={onPublishAll}
aria-label="Publish all changes" aria-label="Publish all changes"
@@ -616,8 +616,8 @@ export function DashboardEditor({
</span> </span>
<Button <Button
variant="outline" variant="outline"
size="sm" size="sm-touch"
className="h-11 shrink-0 md:h-8" className="shrink-0"
onClick={reflow} onClick={reflow}
data-testid="reflow-canvas" data-testid="reflow-canvas"
> >
@@ -630,8 +630,8 @@ export function DashboardEditor({
<TooltipTrigger asChild> <TooltipTrigger asChild>
<Button <Button
variant="ghost" variant="ghost"
size="icon" size="icon-touch"
className="size-11 text-muted-foreground md:size-8" className="text-muted-foreground"
onClick={() => setPaletteOpen(true)} onClick={() => setPaletteOpen(true)}
aria-label="Add widget" aria-label="Add widget"
data-testid="add-widget" data-testid="add-widget"
@@ -646,9 +646,9 @@ export function DashboardEditor({
<TooltipTrigger asChild> <TooltipTrigger asChild>
<Button <Button
variant="ghost" variant="ghost"
size="icon" size="icon-touch"
className={cn( className={cn(
"size-11 text-muted-foreground md:size-8", "text-muted-foreground",
settingsOpen && "text-primary", settingsOpen && "text-primary",
)} )}
onClick={() => { onClick={() => {
@@ -675,8 +675,8 @@ export function DashboardEditor({
<TooltipTrigger asChild> <TooltipTrigger asChild>
<Button <Button
variant="ghost" variant="ghost"
size="icon" size="icon-touch"
className="size-11 text-muted-foreground md:size-8" className="text-muted-foreground"
onClick={() => setDiscardOpen(true)} onClick={() => setDiscardOpen(true)}
aria-label="Discard the unpublished changes" aria-label="Discard the unpublished changes"
data-testid="discard-dashboard" data-testid="discard-dashboard"
@@ -697,8 +697,8 @@ export function DashboardEditor({
<span> <span>
<Button <Button
variant="ghost" variant="ghost"
size="icon" size="icon-touch"
className="size-11 text-muted-foreground md:size-8" className="text-muted-foreground"
onClick={() => void publishDashboard()} onClick={() => void publishDashboard()}
disabled={ disabled={
!hasDraft || publish.isPending || save.isPending !hasDraft || publish.isPending || save.isPending
@@ -736,8 +736,8 @@ export function DashboardEditor({
<TooltipTrigger asChild> <TooltipTrigger asChild>
<Button <Button
variant="ghost" variant="ghost"
size="icon" size="icon-touch"
className="size-11 text-muted-foreground md:size-8" className="text-muted-foreground"
aria-label="Open the panel view" aria-label="Open the panel view"
data-testid="open-view" data-testid="open-view"
asChild asChild
@@ -756,8 +756,7 @@ export function DashboardEditor({
<Button <Button
variant={edit ? "brand" : "secondary"} variant={edit ? "brand" : "secondary"}
size="sm" size="sm-touch"
className="h-11 gap-1.5 md:h-8"
onClick={() => setEdit(!edit)} onClick={() => setEdit(!edit)}
data-testid="toggle-edit" data-testid="toggle-edit"
> >
@@ -274,11 +274,8 @@ function PanelRow({
</span> </span>
<Button <Button
variant={confirmRemove ? "destructive" : "ghost"} variant={confirmRemove ? "destructive" : "ghost"}
size="icon" size="icon-touch"
className={cn( className={cn("shrink-0", !confirmRemove && "text-muted-foreground")}
"size-11 shrink-0 md:size-8",
!confirmRemove && "text-muted-foreground",
)}
aria-label={removeLabel} aria-label={removeLabel}
title={removeLabel} title={removeLabel}
data-testid={`remove-panel-${panel.id}`} data-testid={`remove-panel-${panel.id}`}
+16 -21
View File
@@ -148,8 +148,8 @@ export function FlowDock({
<TooltipTrigger asChild> <TooltipTrigger asChild>
<Button <Button
variant="ghost" variant="ghost"
size="icon" size="icon-touch"
className="size-11 text-muted-foreground md:size-8" className="text-muted-foreground"
onClick={onAddNode} onClick={onAddNode}
aria-label="Add node" aria-label="Add node"
data-testid="add-node" data-testid="add-node"
@@ -171,8 +171,8 @@ export function FlowDock({
<TooltipTrigger asChild> <TooltipTrigger asChild>
<Button <Button
variant="ghost" variant="ghost"
size="icon" size="icon-touch"
className="hidden text-muted-foreground md:inline-flex md:size-8" className="hidden text-muted-foreground md:inline-flex"
onClick={() => fitView({ ...FIT_VIEW, duration: 300 })} onClick={() => fitView({ ...FIT_VIEW, duration: 300 })}
aria-label="Fit the flow to the screen" aria-label="Fit the flow to the screen"
> >
@@ -190,9 +190,8 @@ export function FlowDock({
/> />
<Button <Button
variant="ghost" variant="ghost"
size="sm" size="sm-touch"
className={cn( className={cn(
"h-11 gap-1.5 md:h-8",
faults.length > 0 faults.length > 0
? "text-destructive" ? "text-destructive"
: issuesOpen : issuesOpen
@@ -220,11 +219,8 @@ export function FlowDock({
<TooltipTrigger asChild> <TooltipTrigger asChild>
<Button <Button
variant="ghost" variant="ghost"
size="icon" size="icon-touch"
className={cn( className={cn("text-muted-foreground", paused && "text-primary")}
"size-11 text-muted-foreground md:size-8",
paused && "text-primary",
)}
onClick={onTogglePause} onClick={onTogglePause}
disabled={!enabled} disabled={!enabled}
aria-label={paused ? "Resume flow" : "Pause flow"} aria-label={paused ? "Resume flow" : "Pause flow"}
@@ -247,8 +243,8 @@ export function FlowDock({
<TooltipTrigger asChild> <TooltipTrigger asChild>
<Button <Button
variant="ghost" variant="ghost"
size="icon" size="icon-touch"
className="size-11 text-muted-foreground md:size-8" className="text-muted-foreground"
onClick={onStep} onClick={onStep}
disabled={stepping} disabled={stepping}
aria-label="Step the flow" aria-label="Step the flow"
@@ -266,8 +262,7 @@ export function FlowDock({
<span> <span>
<Button <Button
variant="brand" variant="brand"
size="sm" size="sm-touch"
className="h-11 gap-1.5 md:h-8"
onClick={onRun} onClick={onRun}
disabled={running || !enabled} disabled={running || !enabled}
data-testid="run-flow" data-testid="run-flow"
@@ -295,8 +290,8 @@ export function FlowDock({
<TooltipTrigger asChild> <TooltipTrigger asChild>
<Button <Button
variant="ghost" variant="ghost"
size="icon" size="icon-touch"
className="size-11 text-muted-foreground md:size-8" className="text-muted-foreground"
onClick={onEditFlow} onClick={onEditFlow}
aria-label="Flow settings" aria-label="Flow settings"
data-testid="edit-flow" data-testid="edit-flow"
@@ -314,8 +309,8 @@ export function FlowDock({
<TooltipTrigger asChild> <TooltipTrigger asChild>
<Button <Button
variant="ghost" variant="ghost"
size="icon" size="icon-touch"
className="size-11 text-muted-foreground md:size-8" className="text-muted-foreground"
onClick={onDiscard} onClick={onDiscard}
aria-label="Discard the unpublished changes" aria-label="Discard the unpublished changes"
data-testid="discard-draft" data-testid="discard-draft"
@@ -338,8 +333,8 @@ export function FlowDock({
<span> <span>
<Button <Button
variant="ghost" variant="ghost"
size="icon" size="icon-touch"
className="size-11 text-muted-foreground md:size-8" className="text-muted-foreground"
onClick={onPublish} onClick={onPublish}
disabled={!hasDraft || publishing || saving || !connected} disabled={!hasDraft || publishing || saving || !connected}
aria-label="Publish this flow" aria-label="Publish this flow"
+2 -5
View File
@@ -57,11 +57,8 @@ export function LogsTrigger({
<TooltipTrigger asChild> <TooltipTrigger asChild>
<Button <Button
variant="ghost" variant="ghost"
size="icon" size="icon-touch"
className={cn( className={cn("text-muted-foreground", open && "text-primary")}
"size-11 text-muted-foreground md:size-8",
open && "text-primary",
)}
onClick={() => onOpenChange(!open)} onClick={() => onOpenChange(!open)}
aria-pressed={open} aria-pressed={open}
aria-label="Logs" aria-label="Logs"
+4
View File
@@ -30,6 +30,10 @@ const buttonVariants = cva(
icon: "size-9", icon: "size-9",
"icon-sm": "size-8", "icon-sm": "size-8",
"icon-lg": "size-10", "icon-lg": "size-10",
// Touch targets: 44px below `md`, 32px above (DESIGN-GUIDELINES.md →
// Responsive).
"icon-touch": "size-11 md:size-8",
"sm-touch": "h-11 md:h-8 rounded-full gap-1.5 px-3 has-[>svg]:px-2.5",
}, },
}, },
defaultVariants: { defaultVariants: {
@@ -143,8 +143,8 @@ function Dashboards() {
<TooltipTrigger asChild> <TooltipTrigger asChild>
<Button <Button
variant="ghost" variant="ghost"
size="icon" size="icon-touch"
className="size-11 text-muted-foreground md:size-8" className="text-muted-foreground"
aria-label="Panels" aria-label="Panels"
data-testid="open-panels" data-testid="open-panels"
onClick={() => setPanelsOpen(true)} onClick={() => setPanelsOpen(true)}
+2 -2
View File
@@ -160,8 +160,8 @@ function PairPanel() {
{started?.code && navigator.clipboard ? ( {started?.code && navigator.clipboard ? (
<Button <Button
variant="ghost" variant="ghost"
size="icon" size="icon-touch"
className="size-11 shrink-0 text-muted-foreground md:size-8" className="shrink-0 text-muted-foreground"
aria-label="Copy the code" aria-label="Copy the code"
onClick={() => copy(started.code)} onClick={() => copy(started.code)}
> >