Touch is a panel setting, and the rail grows with it
It described the wrong object. A dashboard is a document that may hang on a
hallway tablet and in a desk browser at the same time, and only one of those
has fingers on it — so the flag moves off `DashboardDef.settings` and onto
`PanelDef` as a plain bool, ticked in the Panels dialog. `useCanvasRoot` takes
it as an argument rather than reading the document, and `/panel/{id}` is the
only surface with a panel to ask.
Dropping the message binding with it is deliberate: nothing drove it, and a
flow deciding whether a screen has fingers on it was never the point. A stored
`settings.touch` is inert rather than migrated, which `_check_settings`
skipping unknown names already guaranteed.
The rail was the other half. It had no touch behaviour at all and its 40px
buttons met neither branch of the 44/32 rule. `[data-touch] .dui-rail{-item}`
in `ui/core/core.css` spends the padding and the gap on the buttons instead,
so they reach the 44px target and the rail comes out taller at exactly the
same width — `RAIL_INSET` never moves, and the arrangement under it does not
either.
Also closes the panels-dialog icon gap: `DashboardSummary` carries the `icon`
now, so the dialog draws each assigned dashboard's rail glyph beside its
checkbox. `initials()` went from three identical copies in the looks to one in
`Dashboard/icons.ts`, so the dialog and the rail fall back the same way.
This commit is contained in:
@@ -22,6 +22,7 @@ export function PanelSurface({
|
||||
dashboard,
|
||||
stacked,
|
||||
rail,
|
||||
touch,
|
||||
}: {
|
||||
dashboard: Dashboard
|
||||
/** A landscape arrangement scaled onto a phone comes out at about a fifth of
|
||||
@@ -29,6 +30,8 @@ export function PanelSurface({
|
||||
stacked?: boolean
|
||||
/** The way between this panel's dashboards, drawn on the canvas itself. */
|
||||
rail?: React.ReactNode
|
||||
/** Whether the screen this hangs on is touched. Stated by the panel route. */
|
||||
touch?: boolean
|
||||
}) {
|
||||
return (
|
||||
<div className="relative size-full">
|
||||
@@ -37,12 +40,12 @@ export function PanelSurface({
|
||||
) : (
|
||||
// The panel's own surface, scaled to fit. No dots: nothing is being
|
||||
// arranged here.
|
||||
<CanvasSurface dashboard={dashboard} rail={rail}>
|
||||
<CanvasSurface dashboard={dashboard} rail={rail} touch={touch}>
|
||||
{() => <DashboardView dashboard={dashboard} rail={Boolean(rail)} />}
|
||||
</CanvasSurface>
|
||||
)}
|
||||
{/* Outside the canvas, so it needs the look stated for it. */}
|
||||
<LookProvider dashboard={dashboard}>
|
||||
<LookProvider dashboard={dashboard} touch={touch}>
|
||||
<LockNotice dashboard={dashboard} />
|
||||
</LookProvider>
|
||||
</div>
|
||||
|
||||
Reference in New Issue
Block a user