Let a sweep run more than four at a time, and name the run a failure was in
Concurrent runs sat at 4 whatever FLOW_MAX_CASCADES said: that setting bounds cascades, and the run drivers read a hardcoded MAX_PARALLEL nobody could reach. FLOW_MAX_RUNS is the knob they read now, --max-runs/--max-cascades/--max-workers are the same three as flags on serve, and the engine says which numbers it started with — which is the only way to tell that a settings file was read. Events keep the run they happened in. The payload always carried it and the persist path dropped it, so reading one run's failures meant filtering the engine-wide list; a batch run's id reaches those events now too, since a run has no journaled item to name itself by. Also: a provisioner's 0 means "no deadline" rather than "cancel on the next reconcile", and a command that reaches no engine says how to start one.
This commit is contained in:
@@ -155,7 +155,11 @@ class MetricsCollector:
|
||||
"""Fold one event in. Synchronous: this is arithmetic on dicts."""
|
||||
kind = str(event.get("type") or "")
|
||||
ts = float(event.get("ts") or time.time())
|
||||
run = self._runs.get(str(event.get("run") or ""))
|
||||
# Two different things: the id as the event carries it, which is what a
|
||||
# recorded row keeps, and the live cascade it belongs to — which a batch
|
||||
# run has none of, since nothing here started one for it.
|
||||
run_id = str(event.get("run") or "")[:64]
|
||||
run = self._runs.get(run_id)
|
||||
|
||||
if kind == "node_executed":
|
||||
bucket = self._bucket(event)
|
||||
@@ -199,6 +203,7 @@ class MetricsCollector:
|
||||
detail=(f"{error}\n{traceback}" if traceback else error)[
|
||||
:DETAIL_CAP
|
||||
],
|
||||
run=run_id,
|
||||
)
|
||||
)
|
||||
return
|
||||
@@ -223,6 +228,7 @@ class MetricsCollector:
|
||||
flow=str(event.get("flow") or ""),
|
||||
node=str(event.get("node") or ""),
|
||||
detail=_detail(event) or "Reported itself down.",
|
||||
run=run_id,
|
||||
)
|
||||
)
|
||||
return
|
||||
@@ -247,6 +253,7 @@ class MetricsCollector:
|
||||
flow=str(event.get("flow") or ""),
|
||||
node=str(event.get("node") or event.get("task") or ""),
|
||||
detail=_detail(event),
|
||||
run=run_id,
|
||||
)
|
||||
)
|
||||
|
||||
|
||||
Reference in New Issue
Block a user