Let a node's failure outlive the run that followed it
A node's error cleared the moment it ran again, so a failure that genuinely fired an alert could leave no trace on the canvas by the time anyone looked. The engine records it now — on the node's status, so it survives a reload and every client agrees — and reading the traceback is what clears it. The seam is the event bus, which is where every failing path already meets: a queued live run, an explicit run, a preview, and a single triggered node all publish `node_error`, while the controller's own observer would have seen only one of them. That was half the confusion. The other half: clicking a failed neuron on Home often landed on a flow where everything looked fine. Nodes merge into one neuron by instance key — every InfluxDB node pointing at the same bucket is one neuron — and the click went to whichever flow contributed a member first, not the one that failed. It now goes to the failing member and selects it, and the canvas marks a failing node rather than leaving it to the dot alone. The inject node emitted one payload to every port it declared, whatever their types, so an inject on a bool port carrying the text "true" raised at publish time. Each port gets its own field now, typed and parsed by that port's dtype, and remembers what it last sent. A port that is renamed carries its value with it; one that is removed takes its value with it. An inject written before this keeps emitting exactly what it did. The derived-cron chip also appeared on the delay node, where `interval` is a rate limit and a schedule derived from it means nothing.
This commit is contained in:
@@ -28,6 +28,7 @@ import { scaleIn } from "@/lib/motion"
|
||||
import { BrainEdge, type BrainEdgeData } from "./BrainEdge"
|
||||
import { BrainNode, type BrainNodeData } from "./BrainNode"
|
||||
import "./flow.css"
|
||||
import { liveStore } from "./liveStore"
|
||||
import { graphQueryOptions } from "./queries"
|
||||
import { useFlowSocket } from "./useFlowSocket"
|
||||
|
||||
@@ -228,9 +229,24 @@ function BrainCanvas() {
|
||||
setRevealed(node.id)
|
||||
return
|
||||
}
|
||||
const [flow] = (node.data as BrainNodeData).flows
|
||||
if (flow)
|
||||
navigate({ to: "/flows/$flowName", params: { flowName: flow } })
|
||||
// A neuron merges every node talking to the same thing, and its
|
||||
// flows are in the order they contributed one — which is rarely the
|
||||
// one that failed. So the failing member picks the flow, and takes
|
||||
// its node with it; `flow.node_id`, and neither half can hold a dot.
|
||||
const { members, flows } = node.data as BrainNodeData
|
||||
const failing = members.find(
|
||||
(member) =>
|
||||
liveStore.getFailure(member) ||
|
||||
liveStore.getStatus(member)?.status === "error",
|
||||
)
|
||||
const [memberFlow, nodeId] = (failing ?? "").split(".")
|
||||
const flowName = memberFlow || flows[0]
|
||||
if (flowName)
|
||||
navigate({
|
||||
to: "/flows/$flowName",
|
||||
params: { flowName },
|
||||
search: nodeId ? { node: nodeId } : {},
|
||||
})
|
||||
}}
|
||||
onPaneClick={() => setRevealed(null)}
|
||||
className="brain-flat h-full w-full"
|
||||
|
||||
Reference in New Issue
Block a user